Saying goodbye during signout confirmation errors

Bug #633620 reported by Chris Tusa on 2010-09-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Telegard
High
Chris Tusa

Bug Description

When a user is confirming their NEW registration, they can change an item by menu selection or enter an 'X' to save and continue to login. As allowed by menuinput, the user can also enter a slash command such as '/G'. In this case, the program exits with the following error:

./lib/telegard.rb:192:in `goodbye_fast': undefined method `time_logout=' for nil:NilClass (NoMethodError)
 from ./lib/tgio/input.rb:342:in `menuprompt'
 from ./lib/tglogin/signup.rb:323:in `confirm'
 from ./lib/tglogin.rb:270:in `signup'
 from ./lib/tglogin.rb:85:in `userprompt'
 from ./lib/tglogin.rb:137:in `auth'
 from ./tg.rb:167

This is due to the goodbye function trying to update the session and callhistory. Allowing / commands is also a potential security risk as additional / commands are introduced.

Chris Tusa (chris-tusa) wrote :

This should be corrected by creating a separate Menu option to cancel and quit, as well as a new menuinput or suppression of slash commands in menuinput.

Changed in telegard:
assignee: nobody → Chris Tusa (chris-tusa)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers