Revert arg validation needs better error message

Bug #1581616 reported by Greg Hill
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
taskflow
Fix Released
Undecided
Greg Hill

Bug Description

Due to changes to allow separate revert vs execute args, it now validates both sets of arguments together. This makes the error message ambiguous and it isn't obvious that it failed to validate only the revert argument list.

http://logs.openstack.org/98/315498/3/check/gate-neutron-lbaasv2-dsvm-minimal/1cb0bf8/logs/screen-o-cw.txt.gz#_2016-05-13_13_53_23_591

The code that will need tweaking is here:

https://github.com/openstack/taskflow/blob/master/taskflow/engines/action_engine/engine.py#L407

Greg Hill (greg-hill)
Changed in taskflow:
assignee: nobody → Greg Hill (greg-hill)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to taskflow (master)

Fix proposed to branch: master
Review: https://review.openstack.org/321874

Changed in taskflow:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to taskflow (master)

Reviewed: https://review.openstack.org/321874
Committed: https://git.openstack.org/cgit/openstack/taskflow/commit/?id=8ab0ba9ea8037379dd59a5e972605ac7c6f89e67
Submitter: Jenkins
Branch: master

commit 8ab0ba9ea8037379dd59a5e972605ac7c6f89e67
Author: Greg Hill <email address hidden>
Date: Thu May 26 17:07:03 2016 -0500

    Split revert/execute missing args messages

    To make it more obvious when a revert method is missing
    a dependency, we now identify which method was missing
    the required paramater.

    Change-Id: I24b0d0b01dbd239b92ba444f6ef44273c5ac25d3
    Closes-Bug: 1581616

Changed in taskflow:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/taskflow 2.1.0

This issue was fixed in the openstack/taskflow 2.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.