taskflow

export_to_dot fails with networkx >= 1.11

Bug #1561656 reported by Michael Johnson on 2016-03-24

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	taskflow	Fix Released	High	Michael Johnson

Bug Description

networkx has changed the way they handle pydot libraries, including moving to pydotplus.

With networkx >= 1.11 TaskFlow will error out with:

Traceback (most recent call last):
  File "tools/dump_taskflow_flows.py", line 82, in <module>
    main()
  File "tools/dump_taskflow_flows.py", line 79, in main
    current_engine.compilation.execution_graph.export_to_dot())
  File "/Data/projects/documentflows/octavia/.tox/docs/local/lib/python2.7/site-packages/taskflow/types/graph.py", line 117, in export_to_dot
    return nx.to_pydot(self).to_string()
AttributeError: 'module' object has no attribute 'to_pydot'

Michael Johnson (johnsom) on 2016-03-24

Changed in taskflow:
assignee:	nobody → Michael Johnson (johnsom)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-03-24: Fix proposed to taskflow (master)

Fix proposed to branch: master
Review: https://review.openstack.org/297275

Changed in taskflow:
status:	New → In Progress

Joshua Harlow (harlowja) on 2016-03-24

Changed in taskflow:
importance:	Undecided → High

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-03-25: Fix merged to taskflow (master)

Reviewed: https://review.openstack.org/297275
Committed: https://git.openstack.org/cgit/openstack/taskflow/commit/?id=720ee3792dc45f514d82108f217bb99e538ef98b
Submitter: Jenkins
Branch: master

commit 720ee3792dc45f514d82108f217bb99e538ef98b
Author: Michael Johnson <email address hidden>
Date: Thu Mar 24 17:45:38 2016 +0000

Fix export_to_dot for networkx package changes

The networkx package changed the way they to_pydot works [1].
This patch updates TaskFlow to work with the newer version.

[1] https://github.com/networkx/networkx/commit/f5031dd9c6c1f4b63082c192e1887ea044109aaa

Change-Id: I99f87af0b2bed959fcb43ef611b3186e23bd9549
Closes-Bug: #1561656

Changed in taskflow:
status:	In Progress → Fix Released

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-05-09: Fix included in openstack/taskflow 1.31.0

This issue was fixed in the openstack/taskflow 1.31.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-20: Fix proposed to taskflow (master)

Fix proposed to branch: master
Review: https://review.openstack.org/318996

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-20: Change abandoned on taskflow (master)

Change abandoned by Michael Johnson (<email address hidden>) on branch: master
Review: https://review.openstack.org/318996
Reason: Another patch already includes this fix: https://review.openstack.org/#/c/297784