Test needs to check if int provided as result
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
taskflow |
Fix Released
|
Medium
|
Joshua Harlow |
Bug Description
Due to CI gate timeouts (slow vms...) the following can happen:
TypeError: unsupported operand type(s) for +: 'Failure' and 'int'
http://
2015-07-27 22:43:14.853 | Traceback (most recent call last):
2015-07-27 22:43:14.853 | File "/home/
2015-07-27 22:43:14.853 | yield
2015-07-27 22:43:14.853 | File "/home/
2015-07-27 22:43:14.853 | callable_obj(*args, **kwargs)
2015-07-27 22:43:14.853 | File "/home/
2015-07-27 22:43:14.853 | for _state in self.run_iter():
2015-07-27 22:43:14.854 | File "/home/
2015-07-27 22:43:14.854 | self._change_
2015-07-27 22:43:14.854 | File "/home/
2015-07-27 22:43:14.854 | six.reraise(
2015-07-27 22:43:14.854 | File "/home/
2015-07-27 22:43:14.854 | raise value
2015-07-27 22:43:14.854 | File "/home/
2015-07-27 22:43:14.854 | failure.
2015-07-27 22:43:14.854 | File "/home/
2015-07-27 22:43:14.854 | failures[
2015-07-27 22:43:14.854 | File "/home/
2015-07-27 22:43:14.855 | raise exc.WrappedFail
2015-07-27 22:43:14.855 | taskflow.
So to avoid that we should check if an int was actually returned before further usage (so we don't also mask the initial error).
Changed in taskflow: | |
importance: | Undecided → Medium |
assignee: | nobody → Joshua Harlow (harlowja) |
Changed in taskflow: | |
milestone: | none → 1.22.0 |
status: | Fix Committed → Fix Released |
Fix proposed to branch: master /review. openstack. org/206273
Review: https:/