Avoid copying task detail users tasks results

Bug #1452978 reported by Joshua Harlow
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
taskflow
Fix Released
Critical
Joshua Harlow

Bug Description

It is unsafe to copy users tasks results (since we can not guarnatee they are copyable, even using copy.copy which does a shallow copy); this causes issues like the following with sqlalchemy results:

'''2015-05-07 22:42:51.142 17040 TRACE oslo_messaging.rpc.dispatcher ObjectDereferencedError: Can't emit change event for attribute 'Volume.provider_location' - parent object of type <Volume> has been garbage collected.'''

'Exception during message handling: Can't emit change event for attribute 'Volume.provider_location' - parent object of type <Volume> has been garbage collected.'''

Joshua Harlow (harlowja)
Changed in taskflow:
importance: Undecided → Critical
assignee: nobody → Joshua Harlow (harlowja)
milestone: none → next-liberty
Changed in taskflow:
status: New → In Progress
Revision history for this message
Joshua Harlow (harlowja) wrote :
Revision history for this message
Joshua Harlow (harlowja) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to taskflow (master)

Reviewed: https://review.openstack.org/181288
Committed: https://git.openstack.org/cgit/openstack/taskflow/commit/?id=e6a04193e73bd44450eca9859b035cf91b4fcf4b
Submitter: Jenkins
Branch: master

commit e6a04193e73bd44450eca9859b035cf91b4fcf4b
Author: Joshua Harlow <email address hidden>
Date: Thu May 7 20:49:46 2015 -0700

    Avoid trying to copy tasks results when cloning/copying

    It is not always safe to copy task results so instad of
    trying to copy.copy them just retain the existing results
    in the clone (and avoid copying any users results if
    they exist).

    This appeared to be causing sqlalchemy weak references to
    get garbage collected prematurely in cinder.

    Fixes bug 1452978

    Change-Id: I75e4ad0e9eb50284ff09179565b6d146a8da3d92

Changed in taskflow:
status: In Progress → Fix Committed
Joshua Harlow (harlowja)
Changed in taskflow:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.