Notify acquires lock
Bug #1301091 reported by
Joshua Harlow
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| taskflow |
Fix Released
|
Medium
|
Joshua Harlow | ||
Bug Description
Engine state change notification acquires the state change lock (that's good) but it also invokes the external notification system while holding the same lock (that's bad), this makes it impossible to use the notification mechanism to trigger a further state change from a secondary thread (while notification is underway). It would be useful to let this behavior happen; without deadlock ensuing.
| Changed in taskflow: | |
| assignee: | nobody → Joshua Harlow (harlowja) |
| importance: | Undecided → Medium |
| Changed in taskflow: | |
| status: | New → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to taskflow (master) | #1 |
| Changed in taskflow: | |
| status: | In Progress → Fix Committed |
| Changed in taskflow: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 926994e2b8f9d08
Author: Joshua Harlow <email address hidden>
Date: Tue Apr 1 13:57:04 2014 -0700
Avoid holding the state lock while notifying
To avoid dead lock where a notifier will callback
into the engine to perform a further state transition
make sure we activate the state change notifiation
after locking and not during it.
Fixes bug 1301091
Change-Id: Ic81e15150e44d3