Generalized Merge Failure Handling

Bug #641392 reported by dobey on 2010-09-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Tarmac
High
dobey

Bug Description

Currently, there are several cases where a merge can fail, due to being a pointless merge, having additional revisions after the approved revision, test failures, etc... These failures can also be extended by adding more plug-ins that fail. It would be nice if
there was a general exception class which all these failures inherited from, that had some attributes, such as the comment to add in Launchpad on the merge proposal. This way, any new plug-ins could simply create a new exception class, or use an existing one, and simply set the appropriate attributes in the exception's creation.

These exceptions could all be handled by checking that the exception type is a subclass of the generalized exception. This would simplify the handler code, and the code that needs to raise the exceptions.

I'll have a branch which does this, sometime today.

Related branches

Paul Hummer (rockstar) on 2010-09-18
Changed in tarmac:
status: In Progress → Fix Committed
Paul Hummer (rockstar) on 2010-09-18
Changed in tarmac:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers