missing or misnamed (!=bzr_identity) branch config in tarmac.conf yields confusing behavior

[David Britton]

If you run tarmac like this:

tarmac -v -d lp:~user/project/branch

But tarmac thinks the branch is "lp:project" (the bzr_identity), you get confusing results. Branches get landed without any settings applied to them. Like the 'verify_command', bugresolver, commit message plugins, all don't load and happily appear to succeed (without doing anything).

It's even worse if the 'BRANCH_URL' is unspecified on the command line and multiple branches are used in the config, since then you can get the case where you think your config is correct (tarmac is attempting to land that branch), but it can't read any of the config settings.

[Samuele Pedroni (pedronis)]

this is indeed actually confusing,

if a branch is configured as

[lp:~tanuki/uservice-logging/trunk]
...

instead of (using bzr_identiy)

[lp:uservice-logging]
...

tarmac will happily merge branches but use an empty config so no verify_command is run and no tweaked commit message etc

I think it should either fail to merge (reporting it like any other pre merge failure) or use the config