| 2011-10-13 13:46:47 |
Kostja Osipov |
description |
if --daemonize option is given, and the standard output and error point to a terminal, they are neither closed, nor checked for write to succeed.
If there is no 'logger' option, and stdin/stdout are not redirected, this silently drops all logging messages into the void.
Suggestion: if --daemonize option is given, at least check that stderr/stdout are not a tty, and if they are, check that 'logger' option is given in the configuration file. If neither is the case, do not daemonize, because such daemon configuration is broken. |
if --daemonize option is given, and the standard output and error point to a terminal, they are neither closed, nor checked for write to succeed.
If there is no 'logger' option, and stdin/stdout are not redirected, this silently drops all logging messages into the void.
Suggestion: if --daemonize option is given, at least check that stderr/stdout are not a tty, and if they are, check that 'logger' option is given in the configuration file. If neither is the case, do not daemonize, because such daemon configuration is broken.
Since stdin is left open, you can't start the daemon remotely using ssh or telnet.
For example, this command simply hangs:
ssh host /bin/tarantool_box --config=/etc/tarantool.cfg --background
since the forked child keeps its stdin open and pointing to the terminal.
This is how this problem affects scripting. |
|
