Tokens from initial marking disappear

[Jiri Srba]

Open the ERK example. Go to the simulator (press M), execute the transition r1 (double click it), and return back to the editor (press M again). Now all tokens from the initial marking disappeared.

[Kenneth Yrke Jørgensen (yrke)]

Based on testing, it seems to also affect when changing marking from history.

Looking in the debugger it seems the markings are saved as empty.

Traced the code back to NetworkMarking.Java line 34-36:

<code>
for (TimedPlace place : tapn.places()) {
    place.resetNumberOfTokens();
}
</code>

Git message is: "Fixed initial markings not updating" changed 2023-04-17.

Removing the change fixes the issue, but will properly bring back the old issue.

This might refer to bugs:
https://bugs.launchpad.net/tapaal/+bug/1988664 or
https://bugs.launchpad.net/tapaal/+bug/2016304

I guess we need to revisit this to find a proper fix.

[Jiri Srba (srba)]

Indeed, removing the code above solves the problem with the initial marking but reintroduces this bug: https://bugs.launchpad.net/tapaal/+bug/2016304

[Jiri Srba (srba)]

The problem seems that by removing the tokens from the marking, we modify the initial marking.

[Jiri Srba (srba)]

It is actually me who introduced this problem by modifying TimedPlace.java and adding line 83
this.tokens().clear();

in attempt to fix this bug:

https://bugs.launchpad.net/tapaal/+bug/2037705

I think that line 83 should be deleted and a better fix should be done for the above bug.