TimedPlaceMarkingEdit contains code to keep colored tokens expression consistent

Bug #1933814 reported by Kenneth Yrke Jørgensen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
TAPAAL
Fix Committed
Critical
Peter Haahr Taankvist

Bug Description

This TimedPlaceMarkingEdit class contains (duplicate) code with the following comment:

//This is needed to keep the colored token expression consistent

We should avoid duplicates like this, but it seems even worse that the GUI seems to preform stuff needed to keep the model consistent. This is real bad.

I guess this should be moved add/remove Tokens on the model object and not in the GUI undo/redo.

Related branches

Changed in tapaal:
status: New → Confirmed
importance: Undecided → Critical
milestone: none → cpn
Revision history for this message
Kenneth Yrke Jørgensen (yrke) wrote :

I guess this also relates to the failing test in parsing shared places. Implementation used to use addTokens.

Changed in tapaal:
assignee: nobody → Peter Haahr Taankvist (ptaank)
Revision history for this message
Kenneth Yrke Jørgensen (yrke) wrote :

Also could you have a look at the XML format to save places. Seems to include redundancy fx what is the <text> tag for? Seems not to be parsed in loader?

Revision history for this message
Peter Haahr Taankvist (ptaank) wrote :

I do not think the code for keeping it consistent is needed. For now we a place has colored tokens (in the form of an arc expression) and regular tokens. These do not need to be consistent since they are exclusive in use.

It does not seem to fix the test

Changed in tapaal:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.