Undo delete fails when selecting and deleting to connected object without selecting the arc

[Kenneth Yrke Jørgensen]

To reproduce:
 - Open a net
 - Select a place
 - select a connected tranistion (hold shift)
 - :Connected arcs are automatically selected
 - deselect the arc (hold shift)
 - delete selected object
 - undo

[Kenneth Yrke Jørgensen (yrke)]

Reproduced in tapaal 3.4.0 throws exception

Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
        at pipe.gui.graphicElements.ArcPath.addPointsToGui(ArcPath.java:655)
        at pipe.gui.graphicElements.ArcPath.insertPoint(ArcPath.java:720)
        at pipe.gui.undo.DeleteArcPathPointEdit.undo(DeleteArcPathPointEdit.java:32)
        at pipe.gui.undo.UndoManager.undo(UndoManager.java:114)
        at pipe.gui.GuiFrame$EditAction.actionPerformed(GuiFrame.java:2683)
        at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
        at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
        at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)

[Kenneth Yrke Jørgensen (yrke)]

Confirmed in dev,

Exception in thread "AWT-EventQueue-0" java.lang.IndexOutOfBoundsException: Index: -1, Size: 3
 at java.util.ArrayList.rangeCheckForAdd(ArrayList.java:665)
 at java.util.ArrayList.add(ArrayList.java:477)
 at pipe.gui.graphicElements.ArcPath.insertPoint(ArcPath.java:659)
 at pipe.gui.undo.DeleteArcPathPointEdit.undo(DeleteArcPathPointEdit.java:32)
 at pipe.gui.undo.UndoManager.undo(UndoManager.java:110)

[Kenneth Yrke Jørgensen (yrke)]

In UndoManager deleteSelected there is a special case for ArcPathPoints if the Arcpath is selected:

if (pnObject instanceof ArcPathPoint) {
  if (!((ArcPathPoint) pnObject).getArcPath().getArc().isSelected()) {

Here the arc is not selected, so there might be something an error somewhere related to order of the deletes/redo.

[Kenneth Yrke Jørgensen (yrke)]

In dev, no exception but arcpath point are added back wrong. This is fixed in brach lp:~yrke/tapaal/modelControlsDrawingsurface