Isolated transitions break the query dialog

Bug #1821588 reported by Jiri Srba
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
TAPAAL
Fix Released
Medium
Kenneth Yrke Jørgensen
3.5
Fix Released
Critical
Kenneth Yrke Jørgensen

Bug Description

To reproduce, make a new net with just one transition with no arcs,
make a new query, select CTL query and the dialog does not appear
and the GUI breaks.

Related branches

Revision history for this message
Jiri Srba (srba) wrote :

The issue is that earlier the GUI said that orphan transitions are removed before the verification, this is not working like this anymore in 3.5.0 release.

Revision history for this message
Kenneth Yrke Jørgensen (yrke) wrote :

The bug is related to orphan tranistion check that throws NPE.

Old code: if(!hasShownMessage){
       messenger.displayInfoMessage("There are orphan transitions (no incoming and no outgoing arcs) in the model."
         + System.getProperty("line.separator") + "They will be removed before the verification.");
       hasShownMessage = true;
      }

New Code:
if(!hasShownMessage && !(ExportBatchDialog.isDialogVisible())){
  messenger.displayInfoMessage("There are orphan transitions (no incoming and no outgoing arcs) in the model."
         +
  System.getProperty("line.separator") + "They will be removed before the verification.");
       hasShownMessage = true;
}
else if(ExportBatchDialog.isDialogVisible()) {
  ExportBatchDialog.setNoOrphanTransitions(true);
}

NPE in call isDialogVisible():
public static boolean isDialogVisible() {
  return exportBatchDialog.isVisible();
}

export dialog is NULL.

Revision history for this message
Kenneth Yrke Jørgensen (yrke) wrote :

Code added in revision 961:
merged in branch lp:~tapaal-contributor/tapaal/Batch-export-PNML-XML-queries-1754675
adding batch export of files to PNML and XML

Changed in tapaal:
importance: Critical → Medium
status: New → Confirmed
status: Confirmed → Fix Committed
Changed in tapaal:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.