TAPAAL

Cant draw after closing tab

Bug #1772938 reported by Kenneth Yrke Jørgensen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
TAPAAL
Fix Released
Medium
Kenneth Yrke Jørgensen

Bug Description

To Reproduce:

  - Open two nets
  - Move tab to first net
  - close tab using Ctrl+W (or file close)

If bug is not present, do same actions again.

Related branches

lp:~yrke/tapaal/guirefactor
Jiri Srba: Approve
TAPAAL Reviewers: Pending requested
Diff: 8661 lines (+2256/-3444)
88 files modified
src/dk/aau/cs/gui/BatchProcessingDialog.java (+4/-11)
src/dk/aau/cs/gui/DrawingSurface.java (+0/-11)
src/dk/aau/cs/gui/TabComponent.java (+2/-13)
src/dk/aau/cs/gui/TabContent.java (+43/-43)
src/dk/aau/cs/gui/TemplateExplorer.java (+10/-10)
src/dk/aau/cs/gui/components/PetriNetElementControl.java (+0/-105)
src/dk/aau/cs/gui/components/TextLabel.java (+0/-90)
src/dk/aau/cs/gui/components/TimedPlaceControl.java (+0/-200)
src/dk/aau/cs/gui/components/handlers/ClickHandler.java (+0/-34)
src/dk/aau/cs/gui/components/handlers/DragHandler.java (+0/-50)
src/dk/aau/cs/gui/undo/AddPetriNetControlCommand.java (+0/-29)
src/dk/aau/cs/io/TraceImportExport.java (+5/-5)
src/dk/aau/cs/util/JavaUtil.java (+23/-0)
src/dk/aau/cs/util/Require.java (+5/-0)
src/dk/aau/cs/verification/UPPAAL/Verifyta.java (+2/-6)
src/dk/aau/cs/verification/VerifyTAPN/VerifyPN.java (+2/-6)
src/dk/aau/cs/verification/VerifyTAPN/VerifyTAPN.java (+2/-4)
src/dk/aau/cs/verification/VerifyTAPN/VerifyTAPNDiscreteVerification.java (+2/-3)
src/dk/aau/cs/verification/batchProcessing/BatchProcessingWorker.java (+6/-6)
src/net/tapaal/TAPAAL.java (+7/-2)
src/pipe/dataLayer/DataLayer.java (+1/-8)
src/pipe/dataLayer/Template.java (+1/-1)
src/pipe/gui/AnimationController.java (+178/-244)
src/pipe/gui/AnimationHistoryComponent.java (+5/-5)
src/pipe/gui/AnimationSettings.java (+1/-1)
src/pipe/gui/Animator.java (+24/-24)
src/pipe/gui/CreateGui.java (+42/-299)
src/pipe/gui/DelayEnabledTransitionControl.java (+10/-10)
src/pipe/gui/DrawingSurfaceImpl.java (+25/-32)
src/pipe/gui/Export.java (+8/-9)
src/pipe/gui/ExportBatchDialog.java (+3/-6)
src/pipe/gui/ExtensionFilter.java (+0/-32)
src/pipe/gui/FileFinder.java (+11/-2)
src/pipe/gui/FileFinderImpl.java (+0/-15)
src/pipe/gui/GuiFrame.java (+1383/-1429)
src/pipe/gui/Pipe.java (+4/-22)
src/pipe/gui/RunVerificationBase.java (+1/-12)
src/pipe/gui/SimulationControl.java (+3/-3)
src/pipe/gui/SimulatorFocusTraversalPolicy.java (+3/-3)
src/pipe/gui/StatusBar.java (+23/-26)
src/pipe/gui/Verifier.java (+4/-4)
src/pipe/gui/action/DeletePetriNetObjectAction.java (+0/-98)
src/pipe/gui/action/EditAnnotationBorderAction.java (+1/-1)
src/pipe/gui/action/GuiAction.java (+33/-13)
src/pipe/gui/action/InsertPointAction.java (+0/-41)
src/pipe/gui/action/SplitArcAction.java (+1/-1)
src/pipe/gui/action/SplitArcPointAction.java (+1/-1)
src/pipe/gui/action/ToggleArcPointAction.java (+1/-1)
src/pipe/gui/graphicElements/AnnotationNote.java (+2/-2)
src/pipe/gui/graphicElements/Arc.java (+2/-2)
src/pipe/gui/graphicElements/Note.java (+2/-2)
src/pipe/gui/graphicElements/PetriNetObject.java (+1/-7)
src/pipe/gui/graphicElements/Place.java (+1/-1)
src/pipe/gui/graphicElements/Transition.java (+1/-1)
src/pipe/gui/graphicElements/tapn/TimedInputArcComponent.java (+2/-2)
src/pipe/gui/graphicElements/tapn/TimedPlaceComponent.java (+1/-1)
src/pipe/gui/graphicElements/tapn/TimedTransportArcComponent.java (+2/-2)
src/pipe/gui/handler/ArcHandler.java (+1/-1)
src/pipe/gui/handler/ArcPathPointHandler.java (+1/-1)
src/pipe/gui/handler/LabelHandler.java (+1/-1)
src/pipe/gui/handler/PetriNetObjectHandler.java (+2/-4)
src/pipe/gui/handler/PlaceHandler.java (+3/-5)
src/pipe/gui/handler/PlaceTransitionObjectHandler.java (+5/-5)
src/pipe/gui/handler/SpecialMacHandler.java (+3/-3)
src/pipe/gui/handler/TAPNTransitionHandler.java (+1/-1)
src/pipe/gui/handler/TransitionHandler.java (+4/-5)
src/pipe/gui/undo/AddConstantEdit.java (+2/-2)
src/pipe/gui/undo/DeleteTimedPlaceCommand.java (+1/-1)
src/pipe/gui/undo/RemoveConstantEdit.java (+2/-2)
src/pipe/gui/undo/UpdateConstantEdit.java (+2/-2)
src/pipe/gui/widgets/CTLQueryDialog.java (+4/-4)
src/pipe/gui/widgets/ConstantsDialogPanel.java (+1/-1)
src/pipe/gui/widgets/ConstantsPane.java (+2/-21)
src/pipe/gui/widgets/EngineDialogPanel.java (+10/-14)
src/pipe/gui/widgets/FileBrowser.java (+0/-49)
src/pipe/gui/widgets/FileBrowserImplementation.java (+0/-16)
src/pipe/gui/widgets/GuardDialogue.java (+1/-3)
src/pipe/gui/widgets/NativeFileBrowser.java (+0/-130)
src/pipe/gui/widgets/NativeFileBrowserFallback.java (+0/-132)
src/pipe/gui/widgets/NewTAPNPanel.java (+1/-1)
src/pipe/gui/widgets/PlaceEditorPanel.java (+3/-12)
src/pipe/gui/widgets/QueryDialog.java (+4/-11)
src/pipe/gui/widgets/QueryPane.java (+2/-14)
src/pipe/gui/widgets/TAPNTransitionEditor.java (+0/-1)
src/pipe/gui/widgets/WorkflowDialog.java (+2/-11)
src/pipe/gui/widgets/filebrowser/FileBrowser.java (+50/-0)
src/pipe/gui/widgets/filebrowser/NativeFileBrowser.java (+122/-0)
src/pipe/gui/widgets/filebrowser/NativeFileBrowserFallback.java (+132/-0)
Revision history for this message
Kenneth Yrke Jørgensen (yrke) wrote :

Bug is related to code close action

if ((appTab.getTabCount() > 0) && checkForSave()) {
     // Set GUI mode to noNet
     setGUIMode(GUIMode.noNet);

     int index = appTab.getSelectedIndex();
     appTab.remove(index);
     CreateGui.removeTab(index);
}
need to call setObject linke in other places, need refactoring to have one function to handle closing of tabs.

Changed in tapaal:
assignee: nobody → Kenneth Yrke Jørgensen (yrke)
Revision history for this message
Kenneth Yrke Jørgensen (yrke) wrote :

I will fix this in the refactoring

Revision history for this message
Kenneth Yrke Jørgensen (yrke) wrote :

Implemented a fix by moving all close tab to one function doing it the right way

Changed in tapaal:
status: New → In Progress
Kenneth Yrke Jørgensen (yrke)
Changed in tapaal:
status: In Progress → Fix Committed
importance: Undecided → Medium
Kenneth Yrke Jørgensen (yrke)
Changed in tapaal:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.