redundant subtransaction section

Bug #1813117 reported by qyq
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tap-as-a-service
Invalid
Low
qyq

Bug Description

In neutron_taas/services/taas/taas_plugin.py, every plugin method such as create_tap_service has a redundancy subtransaction section ,eg:
In neutron_taas/services/taas/taas_plugin.py,

......
89 with context.session.begin(subtransactions=True):
90 ts = super(TaasPlugin, self).create_tap_service(context,
91 tap_service)
92 driver_context = sd_context.TapServiceContext(self, context, ts)
93 self.driver.create_tap_service_precommit(driver_context)
......
in line 89:I think "with context.session.begin(subtransactions=True):" is redundant, for in taas_db.create_tap_service and create_tap_service_precommit there exists "with context.session.begin(subtransactions=True):" section.
I wonder whether every such plugin method should delete the section.

qyq (qianyuqiao)
summary: - redundancy subtransaction section
+ redundant subtransaction section
description: updated
description: updated
Revision history for this message
YAMAMOTO Takashi (yamamoto) wrote :

maybe we can remove the one in taas_db.

Changed in tap-as-a-service:
importance: Undecided → Low
status: New → Confirmed
qyq (qianyuqiao)
Changed in tap-as-a-service:
assignee: nobody → qyq (qianyuqiao)
Changed in tap-as-a-service:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.