Inappropriate value of `isAutomaticInvocation` in automatic LCM

Bug #2025461 reported by Masaki UENO
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tacker
In Progress
Medium
Unassigned

Bug Description

In the current Tacker implementation (stable/2023.1), `isAutomaticInvocation` in VnfLcmOpOccV2 will be forcibly set to `False` when a new vnfLcmOpOcc object is created at [1].

```
def new_lcmocc(inst_id, operation, req_body,
               op_state=v2fields.LcmOperationStateType.STARTING):
    now = datetime.utcnow()
    lcmocc = objects.VnfLcmOpOccV2(
        id=uuidutils.generate_uuid(),
        operationState=op_state,
        stateEnteredTime=now,
        startTime=now,
        vnfInstanceId=inst_id,
        operation=operation,
        isAutomaticInvocation=False,
        isCancelPending=False,
        operationParams=req_body)

    return lcmocc
```

On the other hand, Antelope development has a new feature that triggers Heal/Scale automatically by the alert from Prometheus. As defined in SOL002/003, `isAutomaticInvocation` should be `True` for such LCMs, but the above method will create vnfLcmOpOcc with `isAutomaticInvocation = False`.

The problem can be resolved by adding argument definition in `new_lcmocc` method, or create another method that creates VnfLcmOpOccV2 with `isAutomaticInvocation = True` for automatic LCMs.

[1] https://github.com/openstack/tacker/blob/master/tacker/sol_refactored/common/vnflcm_utils.py#L130-L144

Yasufumi Ogawa (yasufum)
Changed in tacker:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tacker (master)

Change abandoned by "Henry van Dyck <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tacker/+/890611
Reason: mistake to review

Changed in tacker:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tacker 10.0.0.0rc1

This issue was fixed in the openstack/tacker 10.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.