| 2023-06-09 05:04:18 |
Masaki UENO |
description |
In the current Tacker implementation (stable/2023.1), generating `404 Not Found` error in delete PM Threshold API does not correctly handled.
[1] is the point where the above bug detected.
```python
if not pm_threshold:
raise sol_ex.PMThresholdNotExist(thresholdId=thresholdId)
```
This process generates an instance of `PMThresholdNotExist` class with `thresholdId` argument. However, the definition of this class requires `threshold_id` for its message[2].
```python
class PMThresholdNotExist(SolHttpError404):
message = _("The specified PM Threshold %(threshold_id)s does not exist.")
```
I think the below change at [1] will resolve this bug:
```python
if not pm_threshold:
raise sol_ex.PMThresholdNotExist(threshold_id=thresholdId)
```
[1] https://github.com/openstack/tacker/blob/stable/2023.1/tacker/sol_refactored/controller/vnfpm_v2.py#L434
[2] https://github.com/openstack/tacker/blob/stable/2023.1/tacker/sol_refactored/common/exceptions.py#L411-L412 |
In the current Tacker implementation (stable/2023.1), generating `404 Not Found` error in delete PM Threshold API does not correctly handled.
[1] is the point where the above bug detected.
```
if not pm_threshold:
raise sol_ex.PMThresholdNotExist(thresholdId=thresholdId)
```
This process generates an instance of `PMThresholdNotExist` class with `thresholdId` argument. However, the definition of this class requires `threshold_id` for its message[2].
```
class PMThresholdNotExist(SolHttpError404):
message = _("The specified PM Threshold %(threshold_id)s does not exist.")
```
I think the below change at [1] will resolve this bug:
```
if not pm_threshold:
raise sol_ex.PMThresholdNotExist(threshold_id=thresholdId)
```
[1] https://github.com/openstack/tacker/blob/stable/2023.1/tacker/sol_refactored/controller/vnfpm_v2.py#L434
[2] https://github.com/openstack/tacker/blob/stable/2023.1/tacker/sol_refactored/common/exceptions.py#L411-L412 |
|
