VnfLcmOperationOccurrenceNotification contain error wrongly

[Itsuro Oda]

According to ETSI SOL003 v3.3.1 5.5.2.17 VnfLcmOperationOccurrenceNotification:
"error" attribute shall be present if the "operationState" attribute is "FAILED_TEMP","FAILED" or "ROLLED_BACK" and shall be absent otherwise.

If the LCM operation has become "FAILED_TEMP" before, VnfLcmOperationOccurrenceNotification contains "error" even if "operationState" is other than "FAILED_TEMP","FAILED" or "ROLLED_BACK" (ex. "PROCESSING") wrongly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tacker/+/873344

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tacker/+/873344
Committed: https://opendev.org/openstack/tacker/commit/dbc2caac583ddf47ffccf9fc9ac8743d95f50779
Submitter: "Zuul (22348)"
Branch: master

commit dbc2caac583ddf47ffccf9fc9ac8743d95f50779
Author: Itsuro Oda <email address hidden>
Date: Thu Feb 9 05:08:08 2023 +0000

    Fix error attribute of LCM notification

    According to ESTI NFV-SOL 003 v3.3.1, "error" attribute of
    VnfLcmOperationOccurrenceNotification shall be present if the
    "operationState" attribute is "FAILED_TEMP","FAILED" or
    "ROLLED_BACK" and shall be absent otherwise.

    Previously if the LCM operation has become "FAILD_TEMP" before,
    VnfLcmOperationOccurrenceNotification contains "error" even if
    the "operationState" is other than "FAILED_TEMP","FAILED" or
    "ROLLED_BACK" (ex. "PROCESSING") wrongly.

    This patch fixes it.

    Closes-Bug: #2006670
    Change-Id: Ie53f149ae7790d36865ad2a052d5003734287e06

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tacker 9.0.0.0rc1 release candidate.