The content of metadata in vnfcResourceInfo is cleared after LCM

[Koji Shimizu]

1. When mgmt driver need to store values to vnfcResourceInfo[].metadata, these values are cleaed after openstack infra driver process.

2. This is because openstack infra driver re-create vnfcResourceInfo[].metadata in every lcm operation and all keys in metadata are refreshed.

3. This affects faultnotification autohealing. when terminate vnf instance, alarmId is expected in vnfcResourceInfo[].metadata but it is not stored. as result, servernotification unregistration is not requested.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tacker/+/872074

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tacker/+/872074
Committed: https://opendev.org/openstack/tacker/commit/f951a43ced091c21d75ffb9152f901af0e64d134
Submitter: "Zuul (22348)"
Branch: master

commit f951a43ced091c21d75ffb9152f901af0e64d134
Author: Koji Shimizu <email address hidden>
Date: Sun Jan 29 15:31:12 2023 +0900

    Fix servernotification metadata issue

    This patch fixes these problems about metadata:
    - vnfcResourceInfo[].metadata.server_notification
      value is not stored in LCM operations.
    - instantiatedVnfInfo.metadata.ServerNotifierFaultID
      value should be a list, not a string.

    Closes-Bug: #2004097
    Change-Id: I06ea7ced6d9a33c067be3e24ab2c4163bef3574c

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tacker 9.0.0.0rc1 release candidate.