Yoga version API verification

Bug #1976440 reported by Yi Feng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tacker
Fix Released
Medium
Yi Feng

Bug Description

After the Yoga version was released, the API and the MgmtDriver were verified and two MgmtDrivers were found to be faulty.

kubernetes_mgmt.py
1.When checking whether the master node has been installed, the value of
 result.get_stderr() is handled incorrectly, so that the master node will not be
 installed.
2.When checking whether the master node has been installed, if you directly call
 RemoteCommandExecutor to send commands, since the VM has not been started, the
 connection will fail, resulting in installation failure.
3.When calling the encapsulated RemoteCommandExecutor function
 _init_commander_and_send_install_scripts(), the exceptions caught are not enough.
4.https://review.opendev.org/c/openstack/tacker/+/830942 modified the input parameter name
 of MgmtDriver, so that MgmtDriver cannot obtain the parameter value.

cnf_nodeport_mgmt.py
1.When implementing the container update patch, it forgot to add a function to
 cnf_nodeport_mgmt.py, which resulted in an error when running python.
2.If the names of the services are similar, the content of haproxy.cfg will be processed
 and modified incorrectly.

Yi Feng (fengyi765)
Changed in tacker:
assignee: nobody → Yi Feng (fengyi765)
description: updated
description: updated
description: updated
description: updated
description: updated
description: updated
description: updated
description: updated
description: updated
Yi Feng (fengyi765)
description: updated
description: updated
description: updated
description: updated
Yi Feng (fengyi765)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tacker (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tacker/+/844762

Changed in tacker:
status: New → In Progress
Yasufumi Ogawa (yasufum)
Changed in tacker:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tacker (master)

Reviewed: https://review.opendev.org/c/openstack/tacker/+/844762
Committed: https://opendev.org/openstack/tacker/commit/9d5a84c2fdd47cf7324569275b96395ae367a1f4
Submitter: "Zuul (22348)"
Branch: master

commit 9d5a84c2fdd47cf7324569275b96395ae367a1f4
Author: Yi Feng <email address hidden>
Date: Mon Jun 6 12:25:14 2022 +0900

    Fixed some bugs for Mgmt Driver

    Tested the Mgmt Driver in the Yoga version and found some bugs.

    To fix these bugs, the following things have been done in this
    patch:

    1. When checking whether the node has k8s installed, since the
       value of result.get_stderr() is a list, an error will occur
       in the if branch, and the value needs to be modified.
    2. Use the _init_commander_and_send_install_scripts function
       instead of the RemoteCommandExecutor function to prevent the
       VM from getting an error when the connection fails during
       the startup phase.
    3. Added the type of exceptions caught by the
       _init_commander_and_send_install_scripts function.
    4. Change the scale_stack_id to scale_out_id_list uniformly to
       solve the parameter mismatch between the input values for
       mgmt_drvier in vnflcm_driver and mgmt_driver.
    5. Add modify_information_start and modify_information_end to
       Mgmt Driver.
    6. When using the Mgmt Driver to modify the content of the
       haproxy configuration file, use the exact match of grep to
       find the corresponding line number.

    Closes-Bug: #1976440
    Change-Id: I94f011fd5061b04dff0840bf90ca10ae2a677874

Changed in tacker:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tacker 8.0.0.0rc1

This issue was fixed in the openstack/tacker 8.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.