affectedVirtualStorage is set as [] in notification when virtual storage is missing in package

[Pooja Singla]

affectedVirtualStorage is set as "affectedVirtualStorage: []" in notification when virtual storage is missing in uploaded vnf package.

Steps to reproduce:
1) Create vnf package by "openstack vnf package create" command
2) Upload vnf package which does not have virtual storage in
 vnfd by "openstack vnf package upload" command.
3) create vnf instance by "openstack vnflcm create" command
4) Instantiate vnf instance by "openstack vnflcm instantiate" command.

Current output : The notification in tacker-conductor logs contains "affectedVirtualStorages": [] when virtual storage is absent in vnfd.

Expected output: affectedVirtualStorages parameter should be absent in notification when virtual storage is not given in vnfd.

[Pooja Singla (psingla)]

I am assigning this bug to me. I will be working on it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tacker/+/841793

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tacker/+/841793
Committed: https://opendev.org/openstack/tacker/commit/0984f29fb139f52d7ffa8f41e3c03f1d5c72b110
Submitter: "Zuul (22348)"
Branch: master

commit 0984f29fb139f52d7ffa8f41e3c03f1d5c72b110
Author: Pooja Singla <email address hidden>
Date: Fri May 13 19:30:24 2022 +0000

    affectedVirtualStorages should not be set

    affectedVirtualStorages should be absent in
    notification when VNFD does not contain virtual
    storage

    Implemented a check during populating
    affectedVirtualStorages, affectedVirtualLinks,
    affectedVnfcs in notification

    Closes-Bug: #1973372
    Change-Id: Ic83359553fb256de83f8cf1578656f842945b6d0

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tacker 8.0.0.0rc1 release candidate.