instantiate fails with extMgdVL but without extVL

[Itsuro Oda]

instantiate of v2 API fails at STARTING and becomes ROLLED_BACK with following conditions.
* extManagedVirtualLinks is specified but extVirtualLinks is not specified in the InstantiateVnfRequest.

The following messages are output in the tacker-conductor log when this bug occurred.

---
ERROR tacker.sol_refactored.conductor.conductor_v2 [req-fa0827dc-0f88-4c47-ae9a-39aada573866 admin admin] STARTING TERMINATE failed: UnboundLocalError: local variable 'ext_vl' referenced before assignment
TRACE tacker.sol_refactored.conductor.conductor_v2 Traceback (most recent call last):
TRACE tacker.sol_refactored.conductor.conductor_v2 File "/opt/stack/tacker/tacker/sol_refactored/conductor/conductor_v2.py", line 88, in _start_lcm_op
TRACE tacker.sol_refactored.conductor.conductor_v2 grant_req, grant = grant_method(context, lcmocc, inst, vnfd)
TRACE tacker.sol_refactored.conductor.conductor_v2 File "/opt/stack/tacker/tacker/sol_refactored/conductor/vnflcm_driver_v2.py", line 320, in terminate_grant
TRACE tacker.sol_refactored.conductor.conductor_v2 for port in ext_vl.extLinkPorts:
TRACE tacker.sol_refactored.conductor.conductor_v2 UnboundLocalError: local variable 'ext_vl' referenced before assignment
---

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tacker/+/816111

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tacker/+/816111
Committed: https://opendev.org/openstack/tacker/commit/8029f4e1012ed261fe4ce4c3a6dff10817ec32d4
Submitter: "Zuul (22348)"
Branch: master

commit 8029f4e1012ed261fe4ce4c3a6dff10817ec32d4
Author: Itsuro Oda <email address hidden>
Date: Mon Nov 1 00:09:03 2021 +0000

    fix contents of grant request

    This patch fixes some attributes of grant request for instantiate
    and terminate of v2 API.

    In the process of fixing bug #1949318 and adding UTs, some other
    mistakes are found and fixed at the same time.

    * fix number of STORAGE resource definitions of instantiate grant
      request is not correct.
    * fix extManagedVLs are included in VL resource definitions of
      instantiate grant mistakenly.
    * fix interpretation of vnfcCpInfo attributes is not correct when
      making terminate grant request.
    * fix an incorrect variable used to handle extManagedVirtualLinkInfo
      when making terminate grant request. (fix bug #1949318)

    Closes-Bug: #1949318
    Change-Id: I61baaee8fec5bb2e1e954900dd2b9361ac594546

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tacker 7.0.0.0rc1 release candidate.