Faild to set up vim monitoring and vim status keeps PENDING

[Ayumu Ueha]

[Problem]

I setup tacker all-in-one environment using current master branch, and I registered new vim but the vim state did not become REACHEABLE.
+----------------------+---------+-----------------+------------+------------+---------+
| ID | Name | Tenant_id | Type | Is Default | Status |
+----------------------+---------+-----------------+------------+------------+---------+
| ece5db1d-0b29-(omit) | vim-k8s | c36983903(omit) | kubernetes | True | PENDING |
+----------------------+---------+-----------------+------------+------------+---------+

Following is Tacker log output:

Feb 05 06:33:25 openstack3 tacker-server[234464]: 2021-02-05 06:33:25.216 WARNING tacker.nfvo.nfvo_plugin [req-d418f404-46ba-4fac-875c-90bb49ab99a9 nfv_user nfv] Failed to set up vim monitoring: mistralclient.api.base.APIException: Execution is missing field "workflow_identifier"

[Reasons]

The cause is that the version of python-mistralclient was upgraded from v4.11 to 4.20 on 2021-01-26.[1]
[1] mistral release history: https://pypi.org/project/python-mistralclient/4.2.0/#history

v4.20 include following commit[2] and ExecutionManager.create method is changed argument `workflow_identifier` to `wf_identifier`:
[2] https://opendev.org/openstack/python-mistralclient/commit/fc6f779b26876d0806946b09b9bc9f5c8be28797?style=split

Therefore, when adding a pingVIM task during VIM registration[3], an error occurred and the registration failed, so it remains PENDING.

[3] https://opendev.org/openstack/tacker/src/branch/master/tacker/nfvo/workflows/vim_monitor/vim_monitor_utils.py#L47
-------
def execute_workflow(mistral_client, workflow):
    return mistral_client.executions.create(
        workflow_identifier=workflow['id'], ** need to change this argument!
        workflow_input=workflow['input'],
        wf_params={})
-------

So, mistral_client.executions.create() method's argument need to change from workflow_identifier to wf_identifier.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tacker 5.0.0.0rc1 release candidate.

[Yasufumi Ogawa (yasufum)]

Fixed: https://review.opendev.org/c/openstack/tacker/+/774211