need to add *kwargs in VnfAbstractDriver.instantiate_vnf()

[LiangLu]

Some patch added parameter while invoking instantiate_vnf() in VnfLcmDriver._instantiate_vnf(),

However kubernetes_driver.instantiate_vnf() doesnot have parameter "plugin", this will cause a parameter unmatch in calling kubernetes_driver.instantiate_vnf()

As a walkaround, we added a patch https://review.opendev.org/c/openstack/tacker/+/764138 to add parameter at kuberntets_driver.instantaite_vnf(), however we need to facing other possible paramter changing in VnfLcmDriver._instantiate_vnf(), as it is invoking both kubernetes_driver and openstack_driver here.

A solve is to add **kwargs in VnfAbstractDriver:
https://opendev.org/openstack/tacker/src/branch/master/tacker/vnfm/infra_drivers/abstract_driver.py#L93

This bug report is aim to solve this problems by as solve above

[Yasufumi Ogawa (yasufum)]

Any update?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tacker/+/821530

[Ashutosh Mishra (ashutosh15)]

I am fixing this bug and I want to change to assignment.

[Hiromu Asahina (h-asahina)]

Sorry to interrupt.
I don't think adding **kwargs is the best solution for this problem, instead we need to just add the lacked parameter.
The abstract driver defines interfaces of infra-drivers, but **kwargs make those interfaces unclear.
Also, those interfaces can be determined in advance.
So, we can just define needed parameters without **kwargs.

[Ashutosh Mishra (ashutosh15)]

Dear Asahina ,

Thanks for your input.
Understand your point, I think adding of **kwargs in the parameter is fine as In some cases the multiple parameters are required and the class which inherit the abstract driver will take care the functional behavior.

[Hiromu Asahina (h-asahina)]

Thank you for your reply.

> the class which inherit the abstract driver will take care the functional behavior.

That's true.
So, why don't you leave the parameter unmatch?
Even if a subclass has different parameters, the code works correctly in Python.

I say this because an abstract class must not depend on any concrete classes.
A concrete class should depend on an abstract class.

Please kindly tell me if I'm wrong.

[renu rani (renur)]

Thank you for reply.

I agree with your point.

It seems this bug is only to take care such scenario.