Package upload is failed

[Toshiaki Takahashi]

The following failure occurred during some functional tests in local environment.
In actual use cases, it may lead to package upload failure.

[FT log]

[2020-10-06 17:02:37.032] Captured traceback:
[2020-10-06 17:02:37.032] ~~~~~~~~~~~~~~~~~~~
[2020-10-06 17:02:37.032] Traceback (most recent call last):
[2020-10-06 17:02:37.032]
[2020-10-06 17:02:37.032] File "/opt/stack/tacker_branch/FT_merge_source/Gerrit/VNF_Package_Modify/tacker/tacker/tests/functional/vnfpkgm/test_vnf_package.py", line 45, in setUp
[2020-10-06 17:02:37.032] self.package_id1 = self._create_and_upload_vnf("vnfpkgm1")
[2020-10-06 17:02:37.032]
[2020-10-06 17:02:37.032] File "/opt/stack/tacker_branch/FT_merge_source/Gerrit/VNF_Package_Modify/tacker/tacker/tests/functional/vnfpkgm/test_vnf_package.py", line 187, in _create_and_upload_vnf
[2020-10-06 17:02:37.032] self._wait_for_onboard(vnf_package['id'])
[2020-10-06 17:02:37.032]
[2020-10-06 17:02:37.032] File "/opt/stack/tacker_branch/FT_merge_source/Gerrit/VNF_Package_Modify/tacker/tacker/tests/functional/vnfpkgm/test_vnf_package.py", line 91, in _wait_for_onboard
[2020-10-06 17:02:37.032] raise Exception("Failed to onboard vnf package")
[2020-10-06 17:02:37.032]
[2020-10-06 17:02:37.032] Exception: Failed to onboard vnf package

[Itsuro Oda (oda-g)]

NOTE: This bug was caused by https://review.opendev.org/#/c/747511/
and 747511 is the cause of https://review.opendev.org/#/c/755517/

I think https://review.opendev.org/#/c/747511/ should not have been merged.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/756309
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=b4fac9a86b02400d881db2af5e5dd67632f4c6ff
Submitter: Zuul
Branch: master

commit b4fac9a86b02400d881db2af5e5dd67632f4c6ff
Author: Aldinson Esto <email address hidden>
Date: Tue Oct 6 22:54:35 2020 +0900

    Fix for the failure in Package Upload

    This patch is the fix for the failure of uploading VNF package.
    An argument related to VNF artifacts in a onbording function
    didn't exist, so it was added.

    Closes-Bug: #1898818

    Change-Id: I3300963b6f265f7b17e40a80ad77f6078647a197

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/756620

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/756620
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=7c62f82152b7699e41bf603b4e8d22dbd7ced07b
Submitter: Zuul
Branch: stable/victoria

commit 7c62f82152b7699e41bf603b4e8d22dbd7ced07b
Author: Aldinson Esto <email address hidden>
Date: Tue Oct 6 22:54:35 2020 +0900

    Fix for the failure in Package Upload

    This patch is the fix for the failure of uploading VNF package.
    An argument related to VNF artifacts in a onbording function
    didn't exist, so it was added.

    Closes-Bug: #1898818

    Change-Id: I3300963b6f265f7b17e40a80ad77f6078647a197
    (cherry picked from commit b4fac9a86b02400d881db2af5e5dd67632f4c6ff)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tacker 5.0.0.0rc1 release candidate.