vnf package delete command cannot delete package

[Toshiaki Takahashi]

`openstack vnf package delete` cannot delete package.

>>>>--------------------------------------------------------------
$ openstack vnf package create
...
| ID | 722aeb76-75ad-44ae-942d-d289b7ac242b ...
$ openstack vnf package upload --path sample_vnf_pkg.zip 722aeb76-75ad-44ae-942d-d289b7ac242b
Upload request for VNF package 722aeb76-75ad-44ae-942d-d289b7ac242b has been accepted.
$ openstack vnf package update --operational-state DISABLED 722aeb76-75ad-44ae-942d-d289b7ac242b
+-------------------+----------+
| Field | Value |
+-------------------+----------+
| Operational State | DISABLED |
+-------------------+----------+
$ openstack vnf package delete 722aeb76-75ad-44ae-942d-d289b7ac242b
All specified vnf-package(s) deleted successfully

(10 minutes later)

$ openstack vnf package list -c Id
+--------------------------------------+
| Id |
+--------------------------------------+
| 722aeb76-75ad-44ae-942d-d289b7ac242b |
+--------------------------------------+

<<<<--------------------------------------------------------------

Log of tacker-conductor:
>>>>--------------------------------------------------------------
Jul 07 15:37:05 centos8-devstack tacker-conductor[19255]: 2020-07-07 15:37:05.490 TRACE oslo_db.sqlalchemy.exc_filters pymysql.err.InternalError: (1292, "Truncated incorrect DOUBLE value: 'ff63fb35-ab11-46ac-8f5b-52d9ff2851a8'")
Jul 07 15:37:05 centos8-devstack tacker-conductor[19255]: 2020-07-07 15:37:05.490 TRACE oslo_db.sqlalchemy.exc_filters
Jul 07 15:37:05 centos8-devstack tacker-conductor[19255]: 2020-07-07 15:37:05.515 ERROR oslo_messaging.rpc.server [req-98e79638-0223-45b1-b57d-fd5c8aa91a75 admin admin] Exception during message handling: oslo_db.exception.DBError: (pymysql.err.InternalError) (1292, "Truncated incorrect DOUBLE value: 'ff63fb35-ab11-46ac-8f5b-52d9ff2851a8'")
Jul 07 15:37:05 centos8-devstack tacker-conductor[19255]: [SQL: UPDATE vnf_package_vnfd SET updated_at=vnf_package_vnfd.updated_at, deleted_at=%(deleted_at)s, deleted=vnf_package_vnfd.id WHERE vnf_package_vnfd.package_uuid = %(package_uuid_1)s]
Jul 07 15:37:05 centos8-devstack tacker-conductor[19255]: [parameters: {'deleted_at': datetime.datetime(2020, 7, 7, 6, 37, 5, 488988), 'package_uuid_1': '722aeb76-75ad-44ae-942d-d289b7ac242b'}]

<<<<--------------------------------------------------------------

Soft-deleting(=set deleted flag) from vnf_package_vnfd seems failed and deleting from vnf_packages do not executed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/740179

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/740179
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=d744c3936ef6afa4b985e2241be3555b63fb699f
Submitter: Zuul
Branch: master

commit d744c3936ef6afa4b985e2241be3555b63fb699f
Author: Toshiaki Takahashi <email address hidden>
Date: Thu Jul 9 14:59:17 2020 +0900

    Fix: Remove wrong constraint in vnf_package_vnfd

    Currently, vnf_package_vnfd table has a following constraint
    in database created by tacker db migration.
    This is incorrect, so this patch remove the constraint.

    CONSTRAINT `CONSTRAINT_1` CHECK (`deleted` in (0,1))

    This is created because `deleted` was boolean before.
    `deleted` is varchar(36) now, so db migration change its type
    by alter_column method. But this does not remove check constraint.
    This patch add drop_constraint to remove the constraint.

    Change-Id: I7a62ecf3eeec2f363d0f099bb46d3dec7948501a
    Closes-Bug: #1886622
    Signed-off-by: Toshiaki Takahashi <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/755600

[OpenStack Infra (hudson-openstack)]

Change abandoned by Yasufumi Ogawa (<email address hidden>) on branch: stable/victoria
Review: https://review.opendev.org/755600

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/755600
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=aee1a048cba463f1fd8eae8b122dc31c58f80055
Submitter: Zuul
Branch: stable/victoria

commit aee1a048cba463f1fd8eae8b122dc31c58f80055
Author: Toshiaki Takahashi <email address hidden>
Date: Thu Jul 9 14:59:17 2020 +0900

    Fix: Remove wrong constraint in vnf_package_vnfd

    Currently, vnf_package_vnfd table has a following constraint
    in database created by tacker db migration.
    This is incorrect, so this patch remove the constraint.

    CONSTRAINT `CONSTRAINT_1` CHECK (`deleted` in (0,1))

    This is created because `deleted` was boolean before.
    `deleted` is varchar(36) now, so db migration change its type
    by alter_column method. But this does not remove check constraint.
    This patch add drop_constraint to remove the constraint.

    Change-Id: I7a62ecf3eeec2f363d0f099bb46d3dec7948501a
    Closes-Bug: #1886622
    Signed-off-by: Toshiaki Takahashi <email address hidden>
    (cherry picked from commit d744c3936ef6afa4b985e2241be3555b63fb699f)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tacker 5.0.0.0rc1 release candidate.