unused inner-function exists in UT and FT

Bug #1879871 reported by Hiroo Kitamura
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tacker
Fix Released
Undecided
Hiroo Kitamura

Bug Description

In tacker, unused inner-function exists in unittest and functional-test.
Therefore, to improve maintainability, it is better to delete them as dead code.

For example, the following code:

tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack.py
```
    def _get_expected_fields(self):
        return {'stack_name':
                'test_openwrt_eb84260e-5ff7-4332-b032-50a14d6c1123',
                'template': self.hot_template}
```

Changed in tacker:
assignee: nobody → Hiroo Kitamura (h-kitamura)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tacker (master)

Reviewed: https://review.opendev.org/729507
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=527ccfc3a760bbe4ffb79e921212985c7fd7478b
Submitter: Zuul
Branch: master

commit 527ccfc3a760bbe4ffb79e921212985c7fd7478b
Author: Hiroo Kitamura <email address hidden>
Date: Wed May 20 13:40:11 2020 +0900

    trivial: Remove unused inner functions of UT and FT

    Picked up unused fuctions with vulture [1].
    In this patch, from the picked up functions,
    the inner-functions prefixed with '_' are deleted as dead code.
    Only target the inner-function of unittest and functional-test.
    Other functions are left because it's difficult
    to determine if they should be mechanically deleted.

    [1] https://pypi.org/project/vulture/

    Change-Id: I0deb0bdc9e7a7dd1cf7f98f22686ca7727088e22
    Closes-Bug: #1879871

Changed in tacker:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers