test_upload_from_file_and_delete functional test is failing

Bug #1866776 reported by Tushar Patil
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tacker
Fix Released
Undecided
Tushar Patil

Bug Description

Due to recent changes done in the patch: https://review.opendev.org/#/c/707310/, test_upload_from_file_and_delete is failing on py3.

After fixing the issue arising due to py3, the test will still fail further when it will attempt to delete the vnf package.
Reason: It's operationalState is changed from DISABLED to ENABLED after the vnf package is ONBOARDED and if you want to delete vnf package, it's operationalState should be DISABLED and usageState should be NOT_IN_USE. Presently, there is no API to update the operationState to DISABLED and hence this test should be skipped until patch [1] is not merged which will allow us to change the operationalState from ENABLED to DISABLED.

[1] : https://review.opendev.org/#/c/705891

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tacker (master)

Fix proposed to branch: master
Review: https://review.opendev.org/712026

Changed in tacker:
assignee: nobody → Tushar Patil (tpatil)
status: New → In Progress
Revision history for this message
Tushar Patil (tpatil) wrote :

Instead of skipping the tests, I have rebased my patch [1] on "Update vnf package API changes" [2].

[1] : https://review.opendev.org/712026
[2] : https://review.opendev.org/#/c/705891

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tacker (master)

Change abandoned by Tushar Patil (<email address hidden>) on branch: master
Review: https://review.opendev.org/712026
Reason: I have pushed another patch[1] which fixes this problem. Also, there are few extra FTs that are failing which will be fixed in patch [1].

[1] : https://review.opendev.org/#/c/721510

Changed in tacker:
assignee: Tushar Patil (tpatil) → Prashant Bhole (pbhole)
Changed in tacker:
assignee: Prashant Bhole (pbhole) → Tushar Patil (tpatil)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tacker (master)

Reviewed: https://review.opendev.org/721510
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=31beaa32b8bcb63d925d3d3bb458af16af7a0d41
Submitter: Zuul
Branch: master

commit 31beaa32b8bcb63d925d3d3bb458af16af7a0d41
Author: tpatil <email address hidden>
Date: Tue Apr 21 03:06:40 2020 +0000

    Fix FT vnf package functional tests

    test_upload_from_file_and_delete functional test is failing
    as the vnf package 'operationalState' is not DISABLED
    before deletion.

    To fix this issue, I have merged two existing FTs into new one
    which will test the flow - create, upload, update, show and delete.

    * Deleted existing FT
      test_upload_from_file_and_delete
      test_patch_in_onboarded_state
    * Added new FT
      test_upload_from_file_update_show_and_delete.
    * Fixed get vnfd related functional tests by setting package
      operational state to DISABLED before deleting
    * assert_resp_contents method now uses assertCountEqual to compare
      list of string as it ignores order of items in the list.

    Closes-bug: #1866776
    Change-Id: I310f4206527cfe215116f8d85acdb1f519d67a97

Changed in tacker:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers