single yaml file in csar is failed to upload

[nitin uikey]

If VNFD in defined in a sigle yaml file, the csar package is failing while uploading using vnf package API.

package detail ->

vnfpkg_no_meta_single_vnfd.zip
 |-Files
 VNFD_single.yaml

command used -

# create a vnf package
openstack vnf package create

openstack vnf package upload --path vnfpkg_no_meta_single_vnfd.zip <package_UUID_generated_by_create_vnf>

error logs ->

Feb 04 02:09:28 open tacker-conductor[18090]: 2020-02-04 02:09:28.997 DEBUG tacker.objects.vnf_package [req-51d41056-59fd-4446-ba85-172f85b93b73 admin admin] Lazy-loading 'vnf_deployment_flavours' on VnfPackage id 71340db6-a36c-45c4-a930-79cf71808836 from (pid=18090) obj_load_attr /opt/stack/tacker/tacker/objects/vnf_package.py:300
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.033 DEBUG oslo_db.sqlalchemy.engines [req-51d41056-59fd-4446-ba85-172f85b93b73 admin admin] MySQL server mode set to STRICT_TRANS_TABLES,STRICT_ALL_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,TRADITIONAL,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION from (pid=18090) _check_effective_sql_mode /usr/local/lib/python2.7/dist-packages/oslo_db/sqlalchemy/engines.py:307
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 ERROR oslo_messaging.rpc.server [req-51d41056-59fd-4446-ba85-172f85b93b73 admin admin] Exception during message handling: InvalidCSAR: No VNF flavours are available
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server Traceback (most recent call last):
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/server.py", line 165, in _process_incoming
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server res = self.dispatcher.dispatch(message)
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 274, in dispatch
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server return self._do_dispatch(endpoint, method, ctxt, args)
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 194, in _do_dispatch
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server result = func(ctxt, **new_args)
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server File "/opt/stack/tacker/tacker/conductor/conductor_server.py", line 96, in decorated_function
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server vnf_package.save()
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server self.force_reraise()
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server six.reraise(self.type_, self.value, self.tb)
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server File "/opt/stack/tacker/tacker/conductor/conductor_server.py", line 70, in decorated_function
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server return function(self, context, *args, **kwargs)
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server File "/opt/stack/tacker/tacker/conductor/conductor_server.py", line 210, in upload_vnf_package_content
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server context.elevated(), vnf_package.id, zip_path)
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server File "/opt/stack/tacker/tacker/common/csar_utils.py", line 287, in load_csar_data
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server 'error': encodeutils.exception_to_unicode(exp)})
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server self.force_reraise()
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server six.reraise(self.type_, self.value, self.tb)
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server File "/opt/stack/tacker/tacker/common/csar_utils.py", line 281, in load_csar_data
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server return _get_data_from_csar(tosca, context, package_uuid)
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server File "/opt/stack/tacker/tacker/common/csar_utils.py", line 254, in _get_data_from_csar
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server raise exceptions.InvalidCSAR(error_msg)
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server InvalidCSAR: No VNF flavours are available
Feb 04 02:09:29 open tacker-conductor[18090]: 2020-02-04 02:09:29.091 TRACE oslo_messaging.rpc.server

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/706217

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/706217
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=848ab62a8df3726c93c4fba61feb6d072d2e36da
Submitter: Zuul
Branch: master

commit 848ab62a8df3726c93c4fba61feb6d072d2e36da
Author: Niraj <email address hidden>
Date: Fri Jan 31 18:37:25 2020 +0530

    Fix upload vnf_package with single yaml file csar

    This patch fixes the issue for uploading single yaml casr.
    It was reading the flavour details from the nested template
    only in the earlier code.

    Change-Id: Ibf86ed06e940a0b9aaaa8eaf63f3249be1462e36
    Closes-Bug: #1861754