VNF creation failed with error:The Parameter (flavor) was not provided.

[Niraj Singh]

Description
===========

Getting below error while creating VNF using scaling tosca template(tacker/sample/tosca-templates/vnfd/tosca-vnfd-alarm-scale.yaml) by replacing capabilities with flavor as input parameter.
ERROR: ValueError: : resources.SP1_group<nested_stack>.resources.tg4km2x35r7l<SP1_res.yaml>.resources.VDU1: : The Parameter (flavor) was not provided.

Steps to reproduce
==================

1) create vim
tacker vim-register --is-default --description default-vim --config-file samples/vim/vim_config.yaml VIM-openstack

2) create vnfd using attached tosca-template (tosca-vnfd-alarm-scale-with-input-param.yaml).
tacker vnfd-create --vnfd-file tosca-vnfd-alarm-scale-with-input-param.yaml VNFD1

3) Create a parameter file e.g. tosca-vnfd-alarm-scale-param-file.yaml and add below deatils:

 {
  flavor: 'm1.tiny',
 }

4) Create VNF using above parameter file(tosca-vnfd-alarm-scale-param-file.yaml) with below command:
tacker vnf-create --param-file tosca-vnfd-alarm-scale-param-file.yaml --vnfd-name VNFD1 VNF1

Expected result
===============

VNF should create successfully

Actual result
=============

ERROR: ValueError: : resources.SP1_group<nested_stack>.resources.tg4km2x35r7l<SP1_res.yaml>.resources.VDU1: : The Parameter (flavor) was not provided.

Logs
=====
Log Ref: http://paste.openstack.org/show/732956/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/656469

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/656470

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat-translator 1.3.1 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/656469
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=1fe295ca88c73cd3eeec55cb671b1d5a99ac0701
Submitter: Zuul
Branch: master

commit 1fe295ca88c73cd3eeec55cb671b1d5a99ac0701
Author: dharmendra <email address hidden>
Date: Tue Apr 30 08:44:18 2019 +0000

    Update heat-translator-1.3.1 for param values

    If user provides parameter file while creating VNF using scaling policy,
    earlier it was failing with error 'The Parameter was not provided". This issue
    already fixed in heat-translator-1.3.1.
    Update lower-constraints.txt and requirements.txt with the same.

    Depends-On: I67b9f53ac4cc0e4318fb7d62ac3d389c8cafbab2o
    Change-Id: Ie1a6d859f91d8ad2decaaa1606dda1858df782a0
    Closes-Bug: #1823860
    Closes-Bug: #1799683

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/656470
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=aee46c86bbe87cbb8b6ebb3bd9b765aafd13df53
Submitter: Zuul
Branch: stable/stein

commit aee46c86bbe87cbb8b6ebb3bd9b765aafd13df53
Author: dharmendra <email address hidden>
Date: Tue Apr 30 08:44:18 2019 +0000

    Update heat-translator-1.3.1 for param values

    If user provides parameter file while creating VNF using scaling policy,
    earlier it was failing with error 'The Parameter was not provided". This issue
    already fixed in heat-translator-1.3.1.
    Update lower-constraints.txt and requirements.txt with the same.

    Depends-On: I67b9f53ac4cc0e4318fb7d62ac3d389c8cafbab2o
    Change-Id: Ie1a6d859f91d8ad2decaaa1606dda1858df782a0
    Closes-Bug: #1823860
    Closes-Bug: #1799683

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat-translator 1.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tacker 2.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tackerclient 1.0.0 release.