Deletion of VNF is allowed while stack creation is still in CREATE_IN_PROGRESS status

[Tushar Patil]

VNF can be deleted while stack creation is still in progress which leads to orphan resources in heat. There is no way to delete such stacks from tacker anymore.

Steps to reproduce:

1. Create a VNF
2. Check the status of stack in heat, it should be in "CREATE_IN_PROGRESS".
3. Delete the VNF

The VNF is deleted and it's not listed anymore in the vnf-list command but the stack is not deleted. After some time, when the stack is created successfully, it remains there for ever. There is no way operator can delete the stack from tacker.

Expected result: If tacker couldn't delete the stack, it should set the status of VNF to "error" or it should give an 400 error if the VNF status is in "PENDING_CREATE" status.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/618086

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/618086
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=938262073f11913169c79299941d9c5c4d4b0645
Submitter: Zuul
Branch: master

commit 938262073f11913169c79299941d9c5c4d4b0645
Author: Shubham Potale <email address hidden>
Date: Thu Nov 21 20:40:56 2019 +0530

    Delete VNF should fail with 409 error

    If user deletes VNF in "PENDING_CREATE" status, VNF is deleted from
    tacker but the resources created by VIM driver are not cleaned up
    properly. This patch doesn't allow VNF to be deleted if the status is
    in "PENDING_CREATE" status. It will raise 409 error.

    APIImpact
    Return 409 error instead of 200 when VNF is deleted in
    "PENDING_CREATE" status.

    Change-Id: I2de9c3dce5a4b3795119e2550aa8acea68940c45
    Closes-Bug: #1798726