Tacker server throws exception when member action contains UPDATE string.

[Trinath Somanchi]

When an update operation is executed, like,

$> tacker --debug vim-update 2716adb5-8b9b-4d05-b3d7-c1724d2f43cd --name VIM123

Exception will happen by calling this method by a non admin user.

2017-03-25 23:23:38.589 ERROR tacker.api.v1.resource [req-104bc3e8-2435-4d0f-b3d4-733449df46ed demo demo] update failed: No details.
2017-03-25 23:23:38.589 TRACE tacker.api.v1.resource Traceback (most recent call last):
2017-03-25 23:23:38.589 TRACE tacker.api.v1.resource File "/opt/stack/tacker/tacker/api/v1/resource.py", line 77, in resource
2017-03-25 23:23:38.589 TRACE tacker.api.v1.resource result = method(request=request, **args)
2017-03-25 23:23:38.589 TRACE tacker.api.v1.resource File "/opt/stack/tacker/tacker/api/v1/base.py", line 458, in update
2017-03-25 23:23:38.589 TRACE tacker.api.v1.resource orig_obj)
2017-03-25 23:23:38.589 TRACE tacker.api.v1.resource File "/opt/stack/tacker/tacker/policy.py", line 398, in enforce
2017-03-25 23:23:38.589 TRACE tacker.api.v1.resource pluralized)
2017-03-25 23:23:38.589 TRACE tacker.api.v1.resource File "/opt/stack/tacker/tacker/policy.py", line 323, in _prepare_check
2017-03-25 23:23:38.589 TRACE tacker.api.v1.resource match_rule = _build_match_rule(action, target, pluralized)
2017-03-25 23:23:38.589 TRACE tacker.api.v1.resource File "/opt/stack/tacker/tacker/policy.py", line 167, in _build_match_rule
2017-03-25 23:23:38.589 TRACE tacker.api.v1.resource target, action):
2017-03-25 23:23:38.589 TRACE tacker.api.v1.resource File "/opt/stack/tacker/tacker/policy.py", line 93, in _is_attribute_explicitly_set
2017-03-25 23:23:38.589 TRACE tacker.api.v1.resource return (attribute_name in target[attributes.ATTRIBUTES_TO_UPDATE] and
2017-03-25 23:23:38.589 TRACE tacker.api.v1.resource KeyError: 'attributes_to_update'
2017-03-25 23:23:38.589 TRACE tacker.api.v1.resource

This error is thrown when an non-admin user attempts to update an attribute.

========= Proposed Fix ========

>>> if 'update' in action:
change into
>>> if 'update' in action and attributes.ATTRIBUTES_TO_UPDATE in target:

By doing such change, will solve this problem.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/449956

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/452416

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/452416
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=9d9465156e340eba2b8dbeaa79dd7140462a2546
Submitter: Jenkins
Branch: master

commit 9d9465156e340eba2b8dbeaa79dd7140462a2546
Author: Trinath Somanchi <email address hidden>
Date: Sat Apr 1 14:41:16 2017 +0530

    Tacker server throws exception when member action contains UPDATE string.

    When an update operation is executed, like,

    $> tacker --debug vim-update --description "test" VIM0

    Exception will happen by calling this method by a non admin user.

    ...
    tacker.api.v1.resource return (attribute_name in
         target[attributes.ATTRIBUTES_TO_UPDATE] and
    tacker.api.v1.resource KeyError: 'attributes_to_update'
    ...

    Change-Id: I35d5173e9c5c25c7d544e9909da1fbcec931e6b5
    Closes-Bug: #1676074

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tacker 0.8.0 release.