Fix data handling for vnfd, config and param yaml templates

Bug #1591361 reported by Sripriya
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
tacker
Fix Released
Medium
Sridhar Ramaswamy

Bug Description

Refactor the vnfd and vnf api to handle vnfd template, config and param files as json payloads instead of punting it under the generic 'attributes' attribute in VNF/VNFD API.

This will have an impact on DB as well.

Tags: rfe
Sripriya (sseetha)
Changed in tacker:
assignee: nobody → Sripriya (sseetha)
summary: - Fix data handling for vnfd and config yaml templates
+ Fix data handling for vnfd, config and param yaml templates
description: updated
Changed in tacker:
importance: Undecided → Low
Revision history for this message
Sridhar Ramaswamy (srics-r) wrote :

I'd suggest we add "json" payload in addition to "string" version, deprecate "string" version in Newton and remove it in Ocata.

Changed in tacker:
importance: Low → Medium
assignee: Sripriya (sseetha) → nobody
Changed in tacker:
assignee: nobody → Janki Chhatbar (jankihchhatbar)
Sripriya (sseetha)
Changed in tacker:
assignee: Janki Chhatbar (jankihchhatbar) → Sripriya (sseetha)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tacker (master)

Fix proposed to branch: master
Review: https://review.openstack.org/360809

Changed in tacker:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tacker (master)

Reviewed: https://review.openstack.org/360809
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=e8418071bf3fb4555bd546c21b010d6c855357e6
Submitter: Jenkins
Branch: master

commit e8418071bf3fb4555bd546c21b010d6c855357e6
Author: Sripriya <email address hidden>
Date: Thu Aug 25 15:11:01 2016 -0700

    modify vnfd, param & config attr. to dict objects

    vnfd templates, parameter and config files are sent as yaml
    strings in requests body to tacker server.

    Change the attributes to dictionary objects. New behavior
    is applicable to tosca templates only. Also, this change may mangle
    the order of nodes in tosca templates. In order to address this
    concern and preserve the network interfaces order in these nodes,
    there will be follow on patch to address this.

    Change-Id: I05a1d60dc643dca864aff559f37491914b1fcfc3
    Partial-Bug: #1591361

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tacker (master)

Fix proposed to branch: master
Review: https://review.openstack.org/363352

Changed in tacker:
assignee: Sripriya (sseetha) → Sridhar Ramaswamy (srics-r)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tacker (master)

Reviewed: https://review.openstack.org/363352
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=cf7f677fc71d4cac8580a25bfdcd1b93dc689e31
Submitter: Jenkins
Branch: master

commit cf7f677fc71d4cac8580a25bfdcd1b93dc689e31
Author: Sridhar Ramaswamy <email address hidden>
Date: Tue Aug 30 23:57:15 2016 +0000

    Introduce TOSCA 'order' property for connection points

    This is a follow-on to [1] which uses dictionary for VNFD
    template and no longer relies on OrderedDict to preserve
    the order of the node_types in the VNFD template. Instead
    we are going to insist the templates to explicit mention
    the order of the CP.

    [1] https://review.openstack.org/#/c/360809

    Change-Id: Iaf7389305cfea90f158da0eaaa19afe86869541b
    Closes-Bug: #1591361

Changed in tacker:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tacker 0.5.0

This issue was fixed in the openstack/tacker 0.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers