Refactor functional tests base file

Bug #1563189 reported by Santosh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tacker
Fix Released
Low
Sripriya

Bug Description

In file: tacker/tests/functional/base.py

 1. verify_vim file itself as this is particular to VIM CRUD operation asserts and is not applicable for vnfm test . Move it as local function
2. verify placement_attr as well
3. Replace assert False with self.assertFalse

Sripriya (sseetha)
summary: - Changes to be made in file tacker/tests/functional/base.py
+ Refactor functional tests base file
Changed in tacker:
assignee: nobody → Santosh (ksantosh-cs)
Sripriya (sseetha)
Changed in tacker:
status: New → Confirmed
importance: Undecided → Low
assignee: Santosh (ksantosh-cs) → Sripriya (sseetha)
Changed in tacker:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tacker (master)

Reviewed: https://review.openstack.org/299124
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=75c4c518d27d261d0b1c884f11ca0fd4b1a56edf
Submitter: Jenkins
Branch: master

commit 75c4c518d27d261d0b1c884f11ca0fd4b1a56edf
Author: Sripriya <email address hidden>
Date: Tue Mar 29 20:29:01 2016 -0700

    Fix keystone v2 support for multisite

    Placement attr regions returned empty along with vim_project when
    user provides keystone v2 in auth url

    This fixes the vim-register for VIM with keystone v2 version

    Closes-Bug: #1563661
    Closes-Bug: #1563189
    Change-Id: I439a21da6909ca6587dbb3d9de3dc478d02f7158

Changed in tacker:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tacker (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/308055

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tacker (stable/mitaka)

Reviewed: https://review.openstack.org/308055
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=2c43340c9de92e07a357384d33295553206860ae
Submitter: Jenkins
Branch: stable/mitaka

commit 2c43340c9de92e07a357384d33295553206860ae
Author: Sripriya <email address hidden>
Date: Tue Mar 29 20:29:01 2016 -0700

    Fix keystone v2 support for multisite

    Placement attr regions returned empty along with vim_project when
    user provides keystone v2 in auth url

    This fixes the vim-register for VIM with keystone v2 version

    Closes-Bug: #1563661
    Closes-Bug: #1563189
    Change-Id: I439a21da6909ca6587dbb3d9de3dc478d02f7158
    (cherry picked from commit 75c4c518d27d261d0b1c884f11ca0fd4b1a56edf)

tags: added: in-stable-mitaka
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/tacker 0.3.1

This issue was fixed in the openstack/tacker 0.3.1 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/tacker 0.4.0

This issue was fixed in the openstack/tacker 0.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tacker 0.3.1

This issue was fixed in the openstack/tacker 0.3.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.