VNF delete doesn't wait for stack_delete to complete

[Sridhar Ramaswamy]

VNF delete doesn't wait for stack_delete to complete. Instead it just issues heat stack_delete and if that call is successful tacker proceeds to delete the entry from Tacker VNF db.

However under heavy usage, a following vnf-create might fail - due to resource unavailable - as the previous vnf-delete actually didn't wait for the heat stack to be completely removed.

Expected behavior:

Tacker need to hold the vnf in "PENDING_DELETE" state until the underlying heat stack report deletion complete.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/291032

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/308329

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/291032
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=dbbf891fd2043b5c1ec367b89b2bec13b500ee38
Submitter: Jenkins
Branch: master

commit dbbf891fd2043b5c1ec367b89b2bec13b500ee38
Author: dharmendra <email address hidden>
Date: Wed Mar 30 10:02:08 2016 +0530

    Remove premature vnf delete from db

    Hold the vnf in "PENDING_DELETE" state until underlying heat-stack
    deletion is complete.
    Closes-bug: #1554663

    Change-Id: I5c52a9fc55950355f9122cc907f41cb8b9217a5c

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/308329
Committed: https://git.openstack.org/cgit/openstack/tacker-horizon/commit/?id=f51ec2cf363357866563d812c57c3687b4419728
Submitter: Jenkins
Branch: master

commit f51ec2cf363357866563d812c57c3687b4419728
Author: dharmendra <email address hidden>
Date: Mon Apr 25 17:33:03 2016 +0530

    Raise correct error when api.tacker.get_vnf fail

    When api.tacker.get_vnf fail with not found error, raise a correct
    error for handler(i.e. django.http.Http404)

    Change-Id: Ib3b251a59e4306a73f02e56404ee64cea5133471
    Related-Bug: #1554663

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/tacker 0.4.0 release.