remove run_tests.sh

[zeih]

We should remove run_tests.sh since it's rarely used and an alternative exists

We should use Tox.

I would recommend to
1) update TESTING.rst
2) delete run_tests.sh
3) delete
          tools/install_venv.py
          tools/install_venv_common.py
          tools/with_venv.sh

[yong sheng gong (gongysh)]

hope to keep it.

[zeih (zeih)]

hi gongysh,

thx, for raising your voice.
do you use this script and the tools? Can you explain the purpuse you use it?
Is there something that is not possible with tox and testr?

I noticed that several projects has removed the script or discuss to do it:

keystone https://review.openstack.org/#/c/199343/
nova https://review.openstack.org/#/c/285238/
glance started discussion: http://lists.openstack.org/pipermail/openstack-dev/2016-March/088362.html https://review.openstack.org/#/c/287779/
tempest https://review.openstack.org/#/c/270564/
...and so on...

Would be great to discuss it in this bug for tacker projects.

Regards
Martin

[Sridhar Ramaswamy (srics-r)]

I'd support removing run_tests.sh, particularly given [1] is proposed to remove it.

@gongysh - any last words for reasons to keep it ?

[1] https://review.openstack.org/#/c/306927

[venkatamahesh (venkatamaheshkotha)]

There is a patch going on here: https://review.openstack.org/#/c/306927/5

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/306927
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=c93ea2f81155fdbb8fef3ebe909093bb612fff9e
Submitter: Jenkins
Branch: master

commit c93ea2f81155fdbb8fef3ebe909093bb612fff9e
Author: caoyue <email address hidden>
Date: Mon Apr 18 14:43:05 2016 +0800

    Remove virtualenv management scripts from oslo-incubator

    This commit removes the old virtualenv management scripts from oslo
    incubator. They were just wrappers around virtualenv and don't really
    work well in a world with global requirements and constraints. This
    commit just removes them since there isn't any reasons to keep them
    around and remove references to run_tests.sh in the TESTING.rst file

    Closes-Bug: #1553722

    Co-Authored-By: <email address hidden>

    Change-Id: Ieae3698db85377b52687dac58f33a571bc179956

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tacker 0.6.0 release.