Remove device related abstractmethods attach interface and detach interfaces

Bug #1551910 reported by Sripriya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tacker
Fix Released
Low
dharmendra

Bug Description

attach interface and detach interface methods are specific to servicevm and do not apply for vnfm. The interfaces and corresponding implementations in all related files needs to be removed.
See below for the error in tacker server startup logs;

http://paste.openstack.org/show/488823/

Sripriya (sseetha)
tags: added: low-hanging-fruit
Revision history for this message
yong sheng gong (gongysh) wrote :

that is the old device concept, I think, so what about just remove them?

Revision history for this message
Sripriya (sseetha) wrote :

Thats a good idea.

I will update the bug description .

summary: - device driver 'noop' is missing implementation of abstractmethods attach
- interface and detach interfaces
+ Remove device related abstractmethods attach interface and detach
+ interfaces
description: updated
Changed in tacker:
importance: Undecided → Low
Aimee Ukasick (aimeeu)
Changed in tacker:
assignee: nobody → aimee.ukasick (aimeeu)
Aimee Ukasick (aimeeu)
Changed in tacker:
assignee: aimee.ukasick (aimeeu) → nobody
Changed in tacker:
assignee: nobody → Manikantha Srinivas Tadi (manikantha-tadi)
Changed in tacker:
assignee: Manikantha Srinivas Tadi (manikantha-tadi) → dharmendra (dharmendra-kushwaha)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tacker (master)

Reviewed: https://review.openstack.org/298630
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=6f003a46e1da8c9a4ab263a11932fc93834d20c2
Submitter: Jenkins
Branch: master

commit 6f003a46e1da8c9a4ab263a11932fc93834d20c2
Author: dharmendra <email address hidden>
Date: Tue Mar 29 15:10:26 2016 +0530

    Remove unused attach/detach interface method.

    Remove unused attach/detach interface method.
    Closes-Bug: #1551910

    Change-Id: I932c731090a392a9c03e5b518fd2b55ea38613ed

Changed in tacker:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tacker (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/307987

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tacker (stable/mitaka)

Reviewed: https://review.openstack.org/307987
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=903ca80c400eefbd2d93e0a25a8cce282fd0231c
Submitter: Jenkins
Branch: stable/mitaka

commit 903ca80c400eefbd2d93e0a25a8cce282fd0231c
Author: dharmendra <email address hidden>
Date: Tue Mar 29 15:10:26 2016 +0530

    Remove unused attach/detach interface method.

    Remove unused attach/detach interface method.
    Closes-Bug: #1551910

    Change-Id: I932c731090a392a9c03e5b518fd2b55ea38613ed
    (cherry picked from commit 6f003a46e1da8c9a4ab263a11932fc93834d20c2)

tags: added: in-stable-mitaka
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/tacker 0.3.1

This issue was fixed in the openstack/tacker 0.3.1 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/tacker 0.4.0

This issue was fixed in the openstack/tacker 0.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tacker 0.3.1

This issue was fixed in the openstack/tacker 0.3.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.