Clean up references to servicevm in tacker install script

[Sridhar Ramaswamy]

Tacker devstack scripts still refers to the legacy "servicevm" and "advsvc" in the devstack install scripts,

https://github.com/openstack/tacker/blob/master/devstack/lib/tacker

They need to be transitioned to "tacker" and "nfv-role".

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/258404

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/259293

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/264604

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/264604
Committed: https://git.openstack.org/cgit/openstack/tacker-horizon/commit/?id=29f0285d264ca2de823d74bb1b6a0b42968ca583
Submitter: Jenkins
Branch: master

commit 29f0285d264ca2de823d74bb1b6a0b42968ca583
Author: Abdul Rehman <email address hidden>
Date: Wed Jan 6 22:35:14 2016 -0800

    Renamed 'servicevm' in tacker-horizon

    After renaming the service 'servicevm' and 'advsvc' in install file,
    functional tests were failing. Now renamed to 'tacker' in all files of
    python-tackerclient repo so that functional test wouldn't fail.

    Change-Id: I097ccbfb7ae192410400b06bd8796e81e62ee65e
    Partial-Bug: #1524224

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/259293
Committed: https://git.openstack.org/cgit/openstack/python-tackerclient/commit/?id=5903bc93385072f564e08ccbe5a965c9d2d1f9e7
Submitter: Jenkins
Branch: master

commit 5903bc93385072f564e08ccbe5a965c9d2d1f9e7
Author: an.abdulrehman <email address hidden>
Date: Thu Dec 17 22:06:20 2015 -0800

    Renamed 'servicevm' in python-tackerclient

    After renaming the service 'servicevm' and 'advsvc' in install file,
    functional tests were failing. Now renamed to 'tacker' in all files of
    python-tackerclient repo so that functional test wouldn't fail.

    Change-Id: I919d77276af72586a20f50239166325adbf9fb11
    Partial-Bug: #1524224

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/258404
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=3132ca51be153f6a727662c2b1e0de500896b850
Submitter: Jenkins
Branch: master

commit 3132ca51be153f6a727662c2b1e0de500896b850
Author: an.abdulrehman <email address hidden>
Date: Wed Dec 16 02:13:57 2015 -0800

    Renamed 'servicevm' 'advsvc' in tacker install file

    Initially the service name was 'servicevm' and 'advsvc' in install file.
    Now it's been renamed to 'tacker' and 'nfv-role'. Change in install file
    (tacker/devstack/lib/tacker) was necessary to show the updated names
    in horizon/dashboard for tacker service.

    Change-Id: I740f3bfe04525d616c8f7df2847cee8a8d2b1cab
    Depends-on: I919d77276af72586a20f50239166325adbf9fb11
    Depends-on: I097ccbfb7ae192410400b06bd8796e81e62ee65e
    Closes-Bug: #1524224

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/tacker 0.3.0 release.