Capture and show VNF error reason in CLI and Horizon

[Sridhar Ramaswamy]

Request for Enhancement:

When Tacker vnf-create API immediately fails (say due to bad image name or wrong flavor name) there is an error mesg (the reason for the failure is returned). However if the VNF fails,

a) after an attempt to start - say due to resource / host unavailable, some neutron/nova level errors
b) after a failure in healing action - say respawn limit is reached

.. the VNF state is simply moved ERROR state but no reason is display in CLI or Horizon. The operators, now, need to look at the logs to figure out what went wrong. This is huge usability issue.

Tacker's vnf-create backend logic need to be enhanced to ALWAYS capture a reason when a VNF is moved to error state, have this reason returned in vnf-show API and gets displayed both in tackerclient and tacker horizon UI.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/256314

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/256338

[OpenStack Infra (hudson-openstack)]

Change abandoned by bharaththiruveedula (<email address hidden>) on branch: master
Review: https://review.openstack.org/256338
Reason: Duplicate Patch

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/255463
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=edd3b04e5b1e939a4ebbb6d3d9942a7d66b4bd4e
Submitter: Jenkins
Branch: master

commit edd3b04e5b1e939a4ebbb6d3d9942a7d66b4bd4e
Author: Bharath Thiruveedula <email address hidden>
Date: Wed Dec 9 18:20:39 2015 +0530

    Add support to capture error_reason for the VNF

    Partial-Bug: #1524214
    Change-Id: I4897e7e4ebdb8c887fb9882e693e5b3d3f4664e5

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/255464
Committed: https://git.openstack.org/cgit/openstack/tacker-horizon/commit/?id=98b7a5b950d96902e8798f6a98d1014506786d45
Submitter: Jenkins
Branch: master

commit 98b7a5b950d96902e8798f6a98d1014506786d45
Author: Bharath Thiruveedula <email address hidden>
Date: Wed Dec 9 18:24:10 2015 +0530

    Add Error Reason column in VNFManager tab

    Partial-Bug: #1524214
    Change-Id: I0c9d4aac4861f46c59d5e6521cec74e4f3ba1010

[Sridhar Ramaswamy (srics-r)]

Closing the bug as "Fixed" as these two patchsets seems to have take care of the issue raised (both patchsets used Partial-Bug header).