File size check missing for VNFD template, parameter values file and config values file in Horizon and python-tackerclient

Bug #1506593 reported by vishwanath jayaraman on 2015-10-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tacker
Wishlist
sajuptpm

Bug Description

As part of review https://review.openstack.org/#/c/221953/2/tacker_horizon/openstack_dashboard/dashboards/nfv/vnfmanager/forms.py lhcheng raised a good point if we needed to apply file size check for VNFD templates, Parameter value files and config files.
The horizon code at https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py#L680-L692 for file check was referenced as part of the review comment.
Tacker community will need to decide if we want to apply file size limits and the max size to be supported.

Sridhar Ramaswamy (srics-r) wrote :

Make sense to enforce a reasonable max file size. Useful boundary check.

Changed in tacker:
importance: Undecided → Wishlist
Changed in tacker:
assignee: nobody → bharaththiruveedula (bharath-ves)
Sridhar Ramaswamy (srics-r) wrote :

Are you actively working on this ? If not can you please un-assign so that some other community member can work on this ?

Changed in tacker:
assignee: bharaththiruveedula (bharath-ves) → nobody
sajuptpm (sajuptpm) on 2016-06-25
Changed in tacker:
assignee: nobody → sajuptpm (sajuptpm)

Fix proposed to branch: master
Review: https://review.openstack.org/334203

Changed in tacker:
status: New → In Progress
Changed in tacker:
status: In Progress → Invalid
Changed in tacker:
status: Invalid → In Progress
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers