Tacker devstack fails on CentOS 7, due to incorrect apache service name

[Luka Krajger]

Hello,

script devstack/lib/tacker fails on CentOS since there is no "apache2" service. CentOS uses the name "httpd".

Maybe the correct thing here would be to use portable function "restart_apache_server" from devstack/lib/apache? Currently the non-portable command "sudo service apache2 restart" is used...

Error message:
2015-09-22 11:03:59.132 | Installing collected packages: tacker-horizon
2015-09-22 11:03:59.132 | Running setup.py develop for tacker-horizon
2015-09-22 11:03:59.756 | Successfully installed tacker-horizon
2015-09-22 11:03:59.937 | Redirecting to /bin/systemctl restart apache2.service
2015-09-22 11:03:59.946 | Failed to issue method call: Unit apache2.service failed to load: No such file or directory.
2015-09-22 11:03:59.949 | Error on exit

Devstack lib: https://github.com/openstack-dev/devstack/blob/144dbc62f8aa6a62cdca403a69bb883cb8552142/lib/apache

[Sripriya (sseetha)]

Thanks for identifying this bug!

[Luka Krajger (luka-krajger)]

No problem. I am adding a patch tested on CentOS 7, if you guys are willing to use it...

[Sripriya (sseetha)]

Hi Luka,

Kindly go ahead and submit a patchset for this bug. Assigning this bug back to you. The core team will review and merge your patchset. In the patch attached, you do not need the 'sudo service apache2 restart' line as we now are invoking the restart_apache_server method.

Cheers,
Sripriya

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/226887

[Luka Krajger (luka-krajger)]

OK, patch was submitted. Do I need to do anything else?

Thanks for your help :)

[Sripriya (sseetha)]

Thank you Luka for identifying the bug and contributing to Tacker! Congrats on your 1st contribution to OpenStack/Tacker. We are always excited to welcome new developers :-)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/226887
Committed: https://git.openstack.org/cgit/stackforge/tacker/commit/?id=577e464746ce8218764a61c26b950e44395ffc90
Submitter: Jenkins
Branch: master

commit 577e464746ce8218764a61c26b950e44395ffc90
Author: Luka Krajger <email address hidden>
Date: Wed Sep 23 19:07:21 2015 +0200

    Fixes devstack script for CentOS

    Use portable function to restart apache server after tacker-horizon
    installation.

    Change-Id: I8461c671dc67dabb83c006f166dcf9654af639f7
    Closes-Bug: #1498471