Deleting a VNF in PENDING_CREATE state does not delete the associated VM

[vishwanath jayaraman]

Steps to Reproduce the issue
- From either Horizon or CLI, Create VNFs repeatedly until either RAM, vCPU or disk space is exhausted causing the VNF to be in PENDING_CREATE state.
- From either Horizon or CLI, delete the VNF in PENDING_CREATE state, the VNF is successfully deleted, however the associated VM is still present in ERROR state.
The end user expecation in this case would be that the VNF associated VM would be deleted as well.

[vishwanath jayaraman (vishwanathj)]

attaching logs

[Sridhar Ramaswamy (srics-r)]

Vish - thanks for capturing this scenario. It is important for Tacker to gracefully handle error scenarios like,

- errors in template
- instantiation failing due to resource constraints

BTW - is logs.tar.gz from tacker-server ?

[vishwanath jayaraman (vishwanathj)]

logs.tar.gz containts tacker server logs, nova logs and heat logs as well

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/235041

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235041
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=dd54d64fb997ff658ef44f4618ed7c6247496c9f
Submitter: Jenkins
Branch: master

commit dd54d64fb997ff658ef44f4618ed7c6247496c9f
Author: Vishwanath Jayaraman <email address hidden>
Date: Wed Oct 14 19:47:08 2015 -0500

    Fix for deleting VM when VNF is deleted

    This commit adds code to fix the issue of VMs not getting deleted
    when deleting VNFs in PENDING_CREATE or ERROR state.

    Change-Id: Idac5ecc80fb78805f0642e4c08cc73a24640d6bd
    Closes-Bug: #1475798