Tacker: The vnf-create --config-file and --config options should be mutually exclusive

[Bob Haddleton]

The tacker vnf-create command has --config-file and --config options which should be mutually exclusive. If the user specifies both a config file with --config-file and a specific configuration with --config, the text that is read in from the config file will be overwritten by the contents of the --config option.

Updating the add_parameter code to make these two options mutually exclusive will prevent this problem.

[Sridhar Ramaswamy (srics-r)]

Bob, Team:

 I'm wondering why we need to support these two options ? Particularly for a CLI I think we should consider dropping --config.
 The parameter value is limited shell max size. Beyond simple, small sample templates this might actually trip our users.

What do you think ?

[Bob Haddleton (bob-haddleton)]

Sridhar:

I can go either way with this. The same thing applies to the --vnfd argument to vnfd-create, which also has a --vnfd-file argument.

If we look at Heat as a guide, there is no --template option that allows the user to specify the Heat template on the command line, they have to use a file. So it would be reasonable to do the same thing for the vnfd-file

Config may be a little closer to params, which can be specified on the Heat command line. Very simply VNFs might have a small enough set of config changes that would warrant the command line option. But anything more complex will need a file.

So I would vote to remove --config and --vnfd, and make --vnfd-file required.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/211232

[dharmendra (dharmendra-kushwaha)]

This issue already fixed.