tacker

assertRaisesRegexp has been deprecated for assertRaisesRegex

Bug #1436957 reported by Salvador Teran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Invalid
Undecided
Tuan
python-keystoneclient
Fix Released
Low
Steve Martinelli
python-keystoneclient 1.5.0
python-magnumclient
Fix Released
Undecided
Rajat Sharma
tacker
Fix Released
Low
Tuan
watcher
Fix Released
Undecided
Unassigned

Bug Description

I am trying to enable tests using tap format for keystone, once I ran nosetests --with-tap, a warning message was shown for keystoneclient/tests/unit/test_session.py:238: Pending DeprecationWarning: Please use assertRegex instead

Salvador Teran (quijotudo)
Changed in python-keystoneclient:
assignee: nobody → Salvador Teran (quijotudo)
Victor Morales (electrocucaracha)
Changed in python-keystoneclient:
assignee: Salvador Teran (quijotudo) → Victor Morales (electrocucaracha)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/168125

Changed in python-keystoneclient:
status: New → In Progress
OpenStack Infra (hudson-openstack)
Changed in python-keystoneclient:
assignee: Victor Morales (electrocucaracha) → Steve Martinelli (stevemar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/168125
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=cf97f271edf189507827de5c5096118fa6f30b4c
Submitter: Jenkins
Branch: master

commit cf97f271edf189507827de5c5096118fa6f30b4c
Author: Victor Morales <email address hidden>
Date: Thu Mar 26 13:55:23 2015 -0600

    Replace assertRaisesRegexp with assertRaisesRegex

    assertRaisesRegexp is raising a warning message that indicated the
    function is going to be deprecated, use assertRaisesRegex instead.

    Change-Id: Iff3b36ebec5d5d4b75c95c699ab76704d0053137
    Closes-Bug: #1436957

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Morgan Fainberg (mdrnstm)
Changed in python-keystoneclient:
milestone: none → 1.4.0
Morgan Fainberg (mdrnstm)
Changed in python-keystoneclient:
importance: Undecided → Medium
importance: Medium → Low
Morgan Fainberg (mdrnstm)
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tacker (master)

Fix proposed to branch: master
Review: https://review.openstack.org/466173

Changed in tacker:
assignee: nobody → Tuan (tuanla)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/466177

Changed in keystone:
assignee: nobody → Tuan (tuanla)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to watcher (master)

Reviewed: https://review.openstack.org/466172
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=21994297cf86600723d7db7339d110ede9574051
Submitter: Jenkins
Branch: master

commit 21994297cf86600723d7db7339d110ede9574051
Author: Luong Anh Tuan <email address hidden>
Date: Fri May 19 18:02:35 2017 +0700

    Replace assertRaisesRegexp with assertRaisesRegex

    This replaces the deprecated (in python 3.2) unittest.TestCase
    method assertRaisesRegexp() with assertRaisesRegex().

    Change-Id: I38c3055288034aba51c11bb1bccd3655f760cecc
    Closes-Bug: #1436957

Changed in watcher:
status: New → Fix Released
Rajat Sharma (tajar29)
Changed in python-magnumclient:
assignee: nobody → Rajat Sharma (tajar29)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-magnumclient (master)

Reviewed: https://review.openstack.org/466599
Committed: https://git.openstack.org/cgit/openstack/python-magnumclient/commit/?id=fc1ca5d2c524854b20e7504b28cc279b6af6a7a1
Submitter: Jenkins
Branch: master

commit fc1ca5d2c524854b20e7504b28cc279b6af6a7a1
Author: rajat29 <email address hidden>
Date: Mon May 22 11:37:26 2017 +0530

    Replace assertRaisesRegexp with assertRaisesRegex

    This replaces the deprecated (in python 3.2) unittest.TestCase
    method assertRaisesRegexp() with assertRaisesRegex()

    Closes-Bug: #1436957

    Change-Id: I7e2eb18c1b5ecdd1691d7a51087b8a29ca152d89

Changed in python-magnumclient:
status: New → Fix Released
venkatamahesh (venkatamaheshkotha)
Changed in tacker:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by Tuan Luong-Anh (<email address hidden>) on branch: master
Review: https://review.openstack.org/466177

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tacker (master)

Reviewed: https://review.openstack.org/466173
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=ad54b62ef8b15947e486ffa3c2efe4618d119a81
Submitter: Jenkins
Branch: master

commit ad54b62ef8b15947e486ffa3c2efe4618d119a81
Author: Luong Anh Tuan <email address hidden>
Date: Fri May 19 18:12:55 2017 +0700

    Replace assertRaisesRegexp with assertRaisesRegex

    This replaces the deprecated (in python 3.2) unittest.TestCase
    method assertRaisesRegexp() with assertRaisesRegex().

    Change-Id: Ic04e7406610a3b3f1232bc08c0b1ce94adb06827
    Closes-Bug: #1436957

Changed in tacker:
status: In Progress → Fix Released
Revision history for this message
Gage Hugo (gagehugo) wrote :

Keystone has custom test tools [0] for this (which are named the same and slightly confusing). The one assertRaisesRegexp test tool was added [1] as a fix for py26 and is not the same as the function from python 2. It might be useful to change the name of [0] to avoid any future confusion, but for the purpose of this bug, keystone shouldn't need any changes.

[0] https://github.com/openstack/keystone/blob/7754f170aa0eb42bea356e7f912bc241832eb1f3/keystone/tests/unit/core.py#L800
[1] https://review.openstack.org/#/c/39064/

Changed in keystone:
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/watcher 1.2.0

This issue was fixed in the openstack/watcher 1.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron-fwaas 11.0.0.0b2

This issue was fixed in the openstack/neutron-fwaas 11.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-magnumclient 2.6.0

This issue was fixed in the openstack/python-magnumclient 2.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/taskflow 2.13.0

This issue was fixed in the openstack/taskflow 2.13.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/congress 6.0.0.0b3

This issue was fixed in the openstack/congress 6.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/watcher 1.3.0

This issue was fixed in the openstack/watcher 1.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tacker 0.8.0

This issue was fixed in the openstack/tacker 0.8.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.