Admin GUI > General Options > welcome_message not prepending

[Kathy Gee]

In Admin GUI, General Options, there is a text box for entering "List-specific text prepended to new-subscriber welcome message" (welcome_message). When a new member receives the welcome message, whatever text is entered in this text box should appear at the very beginning of the message - it doesn't. This bug applies to both Artemis and ABIWT systems.

[beachbrake (wordsofagirl)]

The value was actually welcome_msg and not welcome_message.

This was a simple change in subscribeack.txt by moving the %(welcome)s to the top. Thankfully I did not have to change any other code like the way it is described at http://systers.org/systers-dev/doku.php/trial_bugs.

Attached patch fixes this.

[Erica Wolfe (erica-wolfe)]

I tested the patch and it appears to work with non-Dlists. If you make the same code changes to a Dlist-specific file, the bug is fixed for both Dlists and non-Dlists. Please see the attached patch.

What are the next steps in verifying this fix?

[Anne Gunn (ompeag)]

Erica,

Just got this. Internet was out this morning (I broke it; I fixed it. :-})

Let me look a bit and get back to you.

ag

--- <email address hidden> wrote:

From: Erica Wolfe <email address hidden>
To: <email address hidden>
Subject: [Bug 348692] Re: Admin GUI > General Options > welcome_message not prepending
Date: Thu, 27 May 2010 15:24:03 -0000

I tested the patch and it appears to work with non-Dlists. If you make
the same code changes to a Dlist-specific file, the bug is fixed for
both Dlists and non-Dlists. Please see the attached patch.

What are the next steps in verifying this fix?

** Attachment added: "bug_348692_patch"
   http://launchpadlibrarian.net/49213886/bug_348692_patch

--
Admin GUI > General Options > welcome_message not prepending
https://bugs.launchpad.net/bugs/348692
You received this bug notification because you are subscribed to
Systers-mailman.

Status in Systers Mailman Custom Modifications: New

Bug description:
In Admin GUI, General Options, there is a text box for entering "List-specific text prepended to new-subscriber welcome message" (welcome_message). When a new member receives the welcome message, whatever text is entered in this text box should appear at the very beginning of the message - it doesn't. This bug applies to both Artemis and ABIWT systems.

[Anne Gunn (ompeag)]

Erica,

Thanks for the precise answers. I wasn't understanding completely before and now I am.

It takes patches to both files to fix the systers version and the non -dyn version should go over to the mailman project as a proposed fix (for a bug they may or may not have opened yet.)

Now we all just need to know what the process for doing all that is.

ag
--- <email address hidden> wrote:

From: erica <email address hidden>
To: <email address hidden>
Cc: Simone Wu <email address hidden>
Subject: Re: Fwd: [Bug 348692] Re: Admin GUI > General Options > welcome_message not prepending
Date: Thu, 27 May 2010 23:18:55 -0400

Anne, responses inline below.
erica

On 5/27/2010 6:15 PM, Anne Gunn wrote:
> Erica,
>
> Could you confirm for me that I am understanding the note for your patch?
>
> You believe, from your testing, that if you only change
> templates/en/subscribeack.txt
> as beachbrake did in her patch, that the problem is fixed but only for non-dlists.
Correct

> But if you change just the one file
> templates/en/subscribeack-dyn.txt
> that, in a dlist installation (one that has our syster's specific code) the problem is fixed for both dlists and regular lists.
>
If you change just subscribeack-dyn.txt, the problem is fixed for only
dlists. In Mailman/Deliverer.py in the Deliverer.SendSubscribeAck
function there is an if/else block which directs dlists to the
subscribeack-dyn.txt file and regular lists to the subscribeack.txt file.
> So, one way to put it would be that beachbrake's fix should be submitted to mailman as a proposed patch for them to consider.
>
Correct
> The change to the -dyn file would be enough to fix the problem for us in our installation.
>
Correct
> And then we need to know whether we thing we should be applying mailman-proposed patches to our mailman installed files or not, if we don't strictly need them.
>
>
I'm not really certain what you're asking, but I'm willing to guess
nonetheless. I think you're asking about keeping the Systers dlist code
'in sync' with the Mailman code. At this point, if similar changes are
made to the subscribeack files for dynamic and regular lists, I don't
see a problem in keeping the changes parallel. Of course, keeping in
mind that I've never fixed a bug before, I'm certain I lack the
experience to forsee problems of this type.
> ag
> --- Begin forwarded message:
>
> From: Erica Wolfe<email address hidden>
> To: <email address hidden>
> Subject: [Bug 348692] Re: Admin GUI> General Options> welcome_message not prepending
> Date: Thu, 27 May 2010 15:24:03 -0000
>
> I tested the patch and it appears to work with non-Dlists. If you make
> the same code changes to a Dlist-specific file, the bug is fixed for
> both Dlists and non-Dlists. Please see the attached patch.
>
> What are the next steps in verifying this fix?
>
> ** Attachment added: "bug_348692_patch"
> http://launchpadlibrarian.net/49213886/bug_348692_patch
>
>

[Robin J (robin-jeffries)]

The process for doing this.

It would be good to follow along (or even contribute to) the testing cycle
coming up. We are going to focus that on the one urgent bug, and not add
extraneous stuff, but this is what we will do later on for the bugs on the
wishlist project.

We need a test case or two. Right now we don't have ways of running
automated tests (hope to fix that by the end of the summer), so a manual
test case: "do X, go to Y to observe result. Test passes if you observe
Z" You can include that with the bug report, so we can easily find it when
it's time.

Someone needs to do a code review of this. I think you have mentors on the
wishlist project who can review this, right? Happy to help if you need me.
 I'm trying to figure out how to do code reviews using launchpad, and I will
send something out next week when I have all the details working. This can
wait till then. Or you may want to have someone review the code for 3 or 4
of these bugs in one round, since the changes are small

In the middle of the summer, we will to an integration and test cycle for
whatever is ready by then (and another one at the end of the summer). At
that point you will want to merge all the fixes you have done so far into
the development branch, and we will run a test cycle to make sure that in
fixing something locally, you didn't break something somewhere else.

Any questions?

Robin

On Fri, May 28, 2010 at 9:13 AM, Anne Gunn <email address hidden> wrote:

> Erica,
>
> Thanks for the precise answers. I wasn't understanding completely
> before and now I am.
>
> It takes patches to both files to fix the systers version and the non
> -dyn version should go over to the mailman project as a proposed fix
> (for a bug they may or may not have opened yet.)
>
> Now we all just need to know what the process for doing all that is.
>
> ag
> --- <email address hidden> wrote:
>
> From: erica <email address hidden>
> To: <email address hidden>
> Cc: Simone Wu <email address hidden>
> Subject: Re: Fwd: [Bug 348692] Re: Admin GUI > General Options >
> welcome_message not prepending
> Date: Thu, 27 May 2010 23:18:55 -0400
>
> Anne, responses inline below.
> erica
>
> On 5/27/2010 6:15 PM, Anne Gunn wrote:
> > Erica,
> >
> > Could you confirm for me that I am understanding the note for your patch?
> >
> > You believe, from your testing, that if you only change
> > templates/en/subscribeack.txt
> > as beachbrake did in her patch, that the problem is fixed but only for
> non-dlists.
> Correct
>
> > But if you change just the one file
> > templates/en/subscribeack-dyn.txt
> > that, in a dlist installation (one that has our syster's specific code)
> the problem is fixed for both dlists and regular lists.
> >
> If you change just subscribeack-dyn.txt, the problem is fixed for only
> dlists. In Mailman/Deliverer.py in the Deliverer.SendSubscribeAck
> function there is an if/else block which directs dlists to the
> subscribeack-dyn.txt file and regular lists to the subscribeack.txt file.
> > So, one way to put it would be that beachbrake's fix should be submitted
> to mailman as a proposed patch for them to consider.
> >
> Correct
> > The change to the -dyn file would be en...

[Erica Wolfe (erica-wolfe)]

Robin,

Thanks so much for the through response!

I have been following along with the systers-dev list. Is there someplace else I should also be following for testing cycle info?

I wrote test cases for regular list and dilst and will post them in subsequent comments.

erica

[Erica Wolfe (erica-wolfe)]

To reproduce the bug in a regular list:

1. Go to the mailing lists - Admin Links page
2. Click "create a new mailing list."
3. On the create a mailing list page, complete the page, ensuring that "Enable dynamic sublists (listname+new?)" is checked No
4. Click "Create List"
5. At the Mailing list creation results page, click "Visit the list's admin page"
6. Enter password and click "Let me in..."
7. Complete the [General Options] section, ensuring that "List-specific text prepended to new-subscriber welcome message" contains "Hello regular list subscriber!" and "Send welcome message to newly subscribed members?" is checked Yes
8. Click "Submit Your Changes"
9. Subscribe a user to the list. If using "Membership Management... -> Mass Subscriptions" ensure that "Send welcome messages to new subscribees?" is checked Yes
10. Check the welcome email, you should see "Hello regular list subscriber!" immediately after "Welcome to the <mailing list name> mailing list!" at the top of the email.

To fix the bug in a regular list:

1. Apply the patch for the subscribeack.txt file

To test the fix:

1. Subscribe a user to the list. If using "Membership Management... -> Mass Subscriptions" ensure that "Send welcome messages to new subscribees?" is checked Yes
2. Check the welcome email, you should see "Hello regular list subscriber!" at the top of the email.

[Erica Wolfe (erica-wolfe)]

To reproduce the bug in a dlist:

1. Go to the mailing lists - Admin Links page
2. Click "create a new mailing list."
3. On the create a mailing list page, complete the page, ensuring that "Enable dynamic sublists (listname+new?)" is checked Yes
4. Click "Create List"
5. At the Mailing list creation results page, click "Visit the list's admin page"
6. Enter password and click "Let me in..."
7. Complete the [General Options] section, ensuring that "List-specific text prepended to new-subscriber welcome message" contains "Hello dlist subscriber!" and "Send welcome message to newly subscribed members?" is checked Yes
8. Click "Submit Your Changes"
9. Subscribe a user to the list. If using "Membership Management... -> Mass Subscriptions" ensure that "Send welcome messages to new subscribees?" is checked Yes
10. Check the welcome email, you should NOT see "Hello dlist subscriber!" anywhere in this email.

To fix the bug in a dlist:

1. Apply the patch for the subscribeack-dyn.txt file

To test the fix:

1. Subscribe a user to the list. If using "Membership Management... -> Mass Subscriptions" ensure that "Send welcome messages to new subscribees?" is checked Yes
2. Check the welcome email, you should see "Hello dlist subscriber!" at the top of the email.

[Erica Wolfe (erica-wolfe)]

Also, I did just notice that this fix puts two blank lines at the top of the welcome email. Is this desirable? If not, one of these blank lines can be removed.

[Erica Wolfe (erica-wolfe)]

http://bazaar.launchpad.net/~erica-wolfe/systers/wishlist/revision/83

Committed revision 83 to the wishlist branch.

Changing the template files that generate the new subscriber welcome emails to include the list-specific welcome text at the start of the email