With systemd 243 libvirt autopkgtest starts failing:
http://autopkgtest.ubuntu.com/packages/libv/libvirt/eoan/amd64
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-eoan/eoan/amd64/libv/libvirt/20190921_104518_69667@/log.gz
...
+ virt-xml-validate debian/tests/smoke-lxc.xml
debian/tests/smoke-lxc.xml validates
+ virsh define debian/tests/smoke-lxc.xml
Domain sl defined from debian/tests/smoke-lxc.xml
+ rm -f /var/log/libvirt/lxc/sl.log
+ virsh start sl
Domain sl started
+ grep -qs starting up /var/log/libvirt/lxc/sl.log
+ check_domain
+ grep/bin/ls
Domain sl has been undefined
-qs sl[[:space:]]\+running
+ virsh list
+ virsh lxc-enter-namespace --noseclabel sl /bin/ls /bin/ls
+ systemctl restart libvirtd
+ check_domain
+ grep -qs sl[[:space:]]\+running
+ virsh list
+ cleanup
+ [ -z ]
+ virsh destroy sl
error: Failed to destroy domain sl
error: Requested operation is not valid: domain is not running
+ true
+ virsh undefine sl
+ CLEANED_UP=1
autopkgtest [10:41:05]: test smoke-lxc: -----------------------]
autopkgtest [10:41:07]: test smoke-lxc: - - - - - - - - - - results - - - - - - - - - -
smoke-lxc FAIL non-zero exit status 1
...
The behaviour change is still present in systemd master (v243-112-g984b96aa7a)
I can revert the change in systemd, but it also fixes an issue reported at upstream.
I will take another look later, but wanted to document my findings.
The commit where the regression is introduced in this commit:
commit 0219b3524f414e2
Author: Donald Buczek <email address hidden>
Date: Thu Apr 25 09:39:41 2019 +0200
cgroup: Continue unit reset if cgroup is busy
When part of the cgroup hierarchy cannot be deleted (e.g. because there
are still processes in it), do not exit unit_prune_cgroup early, but
continue so that u->cgroup_realized is reset.
Log the known case of non-empty cgroups at debug level and other errors
at warning level.
Fixes https:/