Synergy should never raise Exception directly

Bug #1690795 reported by Lisa Zangrando on 2017-05-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Synergy Scheduler Manager
Medium
Lisa Zangrando
Synergy Service
Medium
Lisa Zangrando

Bug Description

The basic Exception and can be used anywhere in your program. In real life, however, no program nor library should ever raise Exception directly: it's not specific enough to be helpful.

Changed in synergy-scheduler-manager:
assignee: nobody → Lisa Zangrando (lisa-zangrando)
importance: Undecided → Low
importance: Low → Wishlist
Changed in synergy-service:
importance: Undecided → Wishlist

Fix proposed to branch: master
Review: https://review.openstack.org/464635

Changed in synergy-service:
status: New → In Progress
Lisa Zangrando (lisa-zangrando) wrote :

Fix #464635

Changed in synergy-service:
importance: Wishlist → Low
status: In Progress → New
Changed in synergy-service:
status: New → In Progress
description: updated

Reviewed: https://review.openstack.org/464635
Committed: https://git.openstack.org/cgit/openstack/synergy-service/commit/?id=a8c06a001ca5f5e2f7dd98a29432238582f5138d
Submitter: Jenkins
Branch: master

commit a8c06a001ca5f5e2f7dd98a29432238582f5138d
Author: Lisa Zangrando <email address hidden>
Date: Mon May 15 15:04:39 2017 +0200

    Synergy should never raise Exception directly

    The basic Exception can be used anywhere in the code but however, no
    program nor library should ever raise Exception directly: it's not
    specific enough to be helpful. This fix better handles the exceptions by
    removing the Exception occurencies and adding a new SynergyError type.

    Bug: #1690795
    Change-Id: I202e063198ee9aef7397bad9b8398c24d52b5fe1
    Sem-Ver: bugfix

Changed in synergy-service:
status: In Progress → Fix Released

Fix proposed to branch: master
Review: https://review.openstack.org/489939

Changed in synergy-scheduler-manager:
status: New → In Progress

Reviewed: https://review.openstack.org/489939
Committed: https://git.openstack.org/cgit/openstack/synergy-scheduler-manager/commit/?id=5923091fda6acacb5896e142672a6cfefa9d1340
Submitter: Jenkins
Branch: master

commit 5923091fda6acacb5896e142672a6cfefa9d1340
Author: Lisa Zangrando <email address hidden>
Date: Wed Aug 2 11:09:08 2017 +0200

    Synergy should never raise Exception

    Replaced any occurrence of "raise Exception" with "raise SynergyError".

    Bug: #1690795
    Change-Id: I064a7219de1323670660dacd02f2513e56981d0c
    Sem-Ver: bugfix

Changed in synergy-scheduler-manager:
status: In Progress → Fix Released
Changed in synergy-service:
milestone: none → 1.5.2
Changed in synergy-scheduler-manager:
milestone: none → 2.5.0
Changed in synergy-scheduler-manager:
importance: Wishlist → High
importance: High → Low
importance: Low → Medium
Changed in synergy-service:
importance: Low → Medium
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers