0.2.99.3 won't build with vala 0.40.0

[Mamoru TASAKA]

Compiling synapse 0.2.99.3 with vala 0.38.8 is okay but with vala 0.40.0 fails like below:

Making all in ui
make[3]: Entering directory '/builddir/build/BUILD/synapse-0.2.99.3/src/ui'
/usr/bin/valac --target-glib=2.40 --thread -g --pkg gdk-x11-3.0 --pkg gtk+-3.0 --pkg gio-2.0 --pkg gio-unix-2.0 --pkg gee-0.8 --pkg json-glib-1.0 --pkg keybinder-3.0 --pkg libnotify --basedir . --directory . --vapidir ../../src/core --pkg synapse-core --vapidir ../../src/plugins --pkg plugins --vapidir ../../vapi ../../vapi/config.vapi --pkg zeitgeist-2.0 -D HAVE_ZEITGEIST -C synapse-main.vala keybindings.vala category.vala interfaces.vala controller.vala model.vala view-base.vala view-default.vala view-essential.vala view-doish.vala view-side-doish.vala view-virgilio.vala widgets.vala widgets-matchlistview.vala icon-cache-service.vala utils.vala settings.vala tile-view/abstract-tile-object.vala tile-view/tile.vala tile-view/tile-view.vala tile-view/wrap-label.vala
...
...
synapse-main.vala:136.43-136.67: warning: Access to static member `Gtk.StatusIcon.position_menu' with an instance reference
        indicator_menu.popup (null, null, status_icon.position_menu, button, event_time);
                                          ^^^^^^^^^^^^^^^^^^^^^^^^^
synapse-main.vala:136.43-136.67: error: Argument 3: Cannot convert from `void Gtk.StatusIcon.position_menu (Gtk.Menu, ref int, ref int, out bool, Gtk.StatusIcon)' to `void Gtk.MenuPositionFunc? (Gtk.Menu, ref int, ref int, out bool)'
        indicator_menu.popup (null, null, status_icon.position_menu, button, event_time);
                                          ^^^^^^^^^^^^^^^^^^^^^^^^^
synapse-main.vala:229.7-229.36: warning: Gdk.Window.process_all_updates has been deprecated since 3.22
synapse-main.vala:242.9-242.31: warning: Gtk.rc_add_default_file has been deprecated since 3.0
synapse-main.vala:243.9-243.26: warning: Gtk.rc_reparse_all has been deprecated since 3.0
Compilation failed: 1 error(s), 134 warning(s)
make[3]: *** [Makefile:1111: synapse.vala.stamp] Error 1
make[3]: Leaving directory '/builddir/build/BUILD/synapse-0.2.99.3/src/ui'
make[2]: *** [Makefile:408: all-recursive] Error 1

[Mamoru TASAKA (mtasaka)]

vala side changed on https://github.com/GNOME/vala/commit/a8e6aff63e5e1502290ba93398314acf2ad45b60

Latest vapi/gtk+-3.0.vapi says
   7258 [Version (since = "2.10")]
   7259 public static void position_menu (Gtk.Menu menu, ref int x, ref int y, out bool push_in, Gtk.StatusIcon user_data);

but
  12320 [CCode (cheader_filename = "gtk/gtk.h", instance_pos = 4.9)]
  12321 public delegate void MenuPositionFunc (Gtk.Menu menu, ref int x, ref int y, out bool push_in);

Maybe annotation of GtkMenuPositionFunc incorrect or gir not updated correctly or something else? (I am not familiar with gobject-introspection or vala or so...)

[Rico Tzschichholz (ricotz)]

Fixed in vala and will be part of its next release 0.40.3

https://git.gnome.org/browse/vala/commit/?id=4b3418e09042ff6f3f8b09cba715316baccd5a99

[Mamoru TASAKA (mtasaka)]

synapse 0.2.99.4 builds with vala 0.40.3. Thank you.