Does not build with Vala 0.36+

[Jan Tojnar]

I am not able to build synapse with anything newer than Vala 0.34. The current version is 0.38.

make[3]: Entering directory '/tmp/nix-build-synapse-0.2.99.2.drv-0/synapse-0.2.99.2/src/core'
  VALAC synapse-core.vala.stamp
desktop-file-service.vala:347.5-347.39: warning: method `Synapse.DesktopFileService.get_cache_file_name' never used
    private string? get_cache_file_name (string dir_name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
result-set.vala:60.5-60.61: error: overriding method `Synapse.ResultSet.iterator' is incompatible with base method `Gee.Iterable.iterator': Base method expected return type `Gee.Iterator<Gee.Map.Entry<Synapse.Match,int>>', but `Gee.Iterator<Gee.Map.Entry<Synapse.Match,int>?>' was provided.
    public Gee.Iterator<Gee.Map.Entry <Match, int>?> iterator ()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation failed: 1 error(s), 1 warning(s)
make[3]: *** [Makefile:804: synapse-core.vala.stamp] Error 1
make[3]: Leaving directory '/tmp/nix-build-synapse-0.2.99.2.drv-0/synapse-0.2.99.2/src/core'
make[2]: *** [Makefile:403: all-recursive] Error 1
make[2]: Leaving directory '/tmp/nix-build-synapse-0.2.99.2.drv-0/synapse-0.2.99.2/src'
make[1]: *** [Makefile:464: all-recursive] Error 1
make[1]: Leaving directory '/tmp/nix-build-synapse-0.2.99.2.drv-0/synapse-0.2.99.2'
make: *** [Makefile:395: all] Error 2

[toralf (toralf-gentoo-bugs)]

    private string? get_cache_file_name (string dir_name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/var/tmp/portage/gnome-extra/synapse-0.2.99.2/work/synapse-0.2.99.2/src/core/result-set.vala:60.5-60.61: error: overriding method `Synapse.ResultSet.iterator' is incompatible with base method `Gee.Iterable.iterator': Base method expected return type `Gee.Iterator<Gee.Map.Entry<Synapse.Match,int>>', but `Gee.Iterator<Gee.Map.Entry<Synapse.Match,int>?>' was provided.
    public Gee.Iterator<Gee.Map.Entry <Match, int>?> iterator ()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation failed: 1 error(s), 1 warning(s)

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 13.0-desktop_20170905-225247

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-6.4.0 *

Available Python interpreters, in order of preference:
  [1] python3.4
  [2] python3.6 (fallback)
  [3] python2.7 (fallback)
  [4] pypy3 (fallback)
  [5] jython2.7 (fallback)
Available Ruby profiles:
  [1] ruby22 (with Rubygems) *
java-config:
The following VMs are available for generation-2:
*) IcedTea JDK 3.5.1 [icedtea-bin-8]
Available Java Virtual Machines:
  [1] icedtea-bin-8 system-vm

emerge -qpv gnome-extra/synapse
[ebuild N ] gnome-extra/synapse-0.2.99.2 USE="zeitgeist -plugins"

[toralf (toralf-gentoo-bugs)]

Created attachment 495520
emerge-info.txt

[toralf (toralf-gentoo-bugs)]

Created attachment 495522
emerge-history.txt

[toralf (toralf-gentoo-bugs)]

Created attachment 495524
environment

[toralf (toralf-gentoo-bugs)]

Created attachment 495526
etc.portage.tbz2

[toralf (toralf-gentoo-bugs)]

Created attachment 495528
gnome-extra:synapse-0.2.99.2:20170919-223928.log

[toralf (toralf-gentoo-bugs)]

Created attachment 495530
logs.tbz2

[toralf (toralf-gentoo-bugs)]

Created attachment 495532
temp.tbz2

[mrc_timer (mrctimer-gentoo-bugs)]

This is fixed in a new version of synapse (0.2.99.3) that was released just a couple of days ago.

[aauren (aauren-gentoo-bugs)]

This bug has been fixed for a couple of months now, would it be possible to get a version bump to 0.2.99.3 or 0.2.99.4 so that Synapse is able to build?

[jer (jer-gentoo-bugs)]

commit 3a111ec801447789eeb4b4309a568a849dda0534
Author: Jeroen Roovers <email address hidden>
Date: Sun Oct 14 14:40:38 2018 +0200

    gnome-extra/synapse: Version 0.2.99.4

    Package-Manager: Portage-2.3.51, Repoman-2.3.11
    Signed-off-by: Jeroen Roovers <email address hidden>