Switchboard Power Plug

Labels overlap each other when using increased font sizes or non-English lang [$50]

Bug #1120327 reported by Trung Ngô
32
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Switchboard Power Plug
Fix Released
Medium
Viko Adi Rahmawan
Switchboard Power Plug 0.2.0

Bug Description

Attached image is how it looks.
The "1h" label is set too close to the "Never" label making them overlap.

Proposed solution: interleave the labels' position: TOP/BOTTOM/TOP/BOTTOM/TOP

Let's see if I can make a patch.

Related branches

lp:~vikoadi/switchboard-plug-power/fix-overlap
David Gomes (community): Approve
Diff: 243 lines (+116/-73)
4 files modified
src/ActionComboBox.vala (+41/-0)
src/CMakeLists.txt (+3/-1)
src/Plug.vala (+11/-72)
src/TimeoutComboBox.vala (+61/-0)
Revision history for this message
Trung Ngô (ndtrung4419) wrote :
Cody Garver (codygarver)
Changed in switchboard-plug-power:
assignee: nobody → elementary UX Team (elementary-design)
Cody Garver (codygarver)
Changed in switchboard-plug-power:
milestone: none → 0.3-beta1
importance: Undecided → Medium
status: New → Confirmed
Cody Garver (codygarver)
summary: - Labels overlap each other in Vietnamese translation
+ Labels overlap each other in translations
Revision history for this message
Cody Garver (codygarver) wrote : Re: Labels overlap each other in translations

Polish too.

Danielle Foré (danrabbit)
Changed in switchboard-plug-power:
milestone: isis-beta1 → none
Revision history for this message
Cody Garver (codygarver) wrote :

Also happens if you have Large Text activated in Universal Access GNOMECC plug

Changed in switchboard-plug-power:
milestone: none → isis-beta2
Revision history for this message
Cody Garver (codygarver) wrote :

Maybe we should have 'Never' as the first label. It becomes "Never - 5 min - 10 min - 30 min - 1 hour"

Revision history for this message
Fabio Zaramella (fabiozaramella) wrote :

i can't reproduce this bug even with large text activated, however it would make much more sense to have the "never" option as the first one.

Revision history for this message
Danielle Foré (danrabbit) wrote :

Yeah I can reproduce with large text as well.

If we can't find the label size and keep them from overlapping (which seems like a massive oversight in this widget's design), perhaps we should use a combobox or a spin button (or a combination of the two) instead.

Changed in switchboard-plug-power:
assignee: elementary UX Team (elementary-design) → nobody
Cody Garver (codygarver)
summary: - Labels overlap each other in translations
+ Labels overlap each other when using increased font sizes or non-English
+ lang
Revision history for this message
Danielle Foré (danrabbit) wrote :

https://www.bountysource.com/issues/1422085-labels-overlap-each-other-when-using-increased-font-sizes-or-non-english-lang

summary: Labels overlap each other when using increased font sizes or non-English
- lang
+ lang [$50]
Viko Adi Rahmawan (vikoadi)
Changed in switchboard-plug-power:
assignee: nobody → Viko Adi Rahmawan (vikoadi)
Danielle Foré (danrabbit)
Changed in switchboard-plug-power:
status: Confirmed → In Progress
RabbitBot (rabbitbot-a)
Changed in switchboard-plug-power:
status: In Progress → Fix Committed
Danielle Foré (danrabbit)
Changed in switchboard-plug-power:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.